Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Source/core/inspector/ScriptCallFrame.h

Issue 23717011: DevTools: Use scriptId for resolving stack frames in console messages (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed tests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 Google Inc. All rights reserved. 2 * Copyright (c) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 21 matching lines...) Expand all
32 #define ScriptCallFrame_h 32 #define ScriptCallFrame_h
33 33
34 #include "InspectorTypeBuilder.h" 34 #include "InspectorTypeBuilder.h"
35 #include "wtf/Forward.h" 35 #include "wtf/Forward.h"
36 #include "wtf/text/WTFString.h" 36 #include "wtf/text/WTFString.h"
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 class ScriptCallFrame { 40 class ScriptCallFrame {
41 public: 41 public:
42 ScriptCallFrame(const String& functionName, const String& scriptName, unsign ed lineNumber, unsigned column = 0); 42 ScriptCallFrame(const String& functionName, const String& scriptId, const St ring& scriptName, unsigned lineNumber, unsigned column = 0);
43 ~ScriptCallFrame(); 43 ~ScriptCallFrame();
44 44
45 const String& functionName() const { return m_functionName; } 45 const String& functionName() const { return m_functionName; }
46 const String& scriptId() const { return m_scriptId; }
46 const String& sourceURL() const { return m_scriptName; } 47 const String& sourceURL() const { return m_scriptName; }
47 unsigned lineNumber() const { return m_lineNumber; } 48 unsigned lineNumber() const { return m_lineNumber; }
48 unsigned columnNumber() const { return m_column; } 49 unsigned columnNumber() const { return m_column; }
49 50
50 bool isEqual(const ScriptCallFrame&) const; 51 bool isEqual(const ScriptCallFrame&) const;
51 52
52 PassRefPtr<TypeBuilder::Console::CallFrame> buildInspectorObject() const; 53 PassRefPtr<TypeBuilder::Console::CallFrame> buildInspectorObject() const;
53 54
54 private: 55 private:
55 String m_functionName; 56 String m_functionName;
57 String m_scriptId;
56 String m_scriptName; 58 String m_scriptName;
57 unsigned m_lineNumber; 59 unsigned m_lineNumber;
58 unsigned m_column; 60 unsigned m_column;
59 }; 61 };
60 62
61 } // namespace WebCore 63 } // namespace WebCore
62 64
63 #endif // ScriptCallFrame_h 65 #endif // ScriptCallFrame_h
OLDNEW
« no previous file with comments | « Source/bindings/v8/ScriptCallStackFactory.cpp ('k') | Source/core/inspector/ScriptCallFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698