Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: Source/core/inspector/ScriptCallFrame.cpp

Issue 23717011: DevTools: Use scriptId for resolving stack frames in console messages (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed tests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/ScriptCallFrame.h ('k') | Source/devtools/front_end/ConsoleMessage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/ScriptCallFrame.cpp
diff --git a/Source/core/inspector/ScriptCallFrame.cpp b/Source/core/inspector/ScriptCallFrame.cpp
index e6d2f6230c4abddb46c4aaf473234adee766b360..4e5989eed04d45e36761af6d3a2dff054e1c3bbc 100644
--- a/Source/core/inspector/ScriptCallFrame.cpp
+++ b/Source/core/inspector/ScriptCallFrame.cpp
@@ -33,8 +33,9 @@
namespace WebCore {
-ScriptCallFrame::ScriptCallFrame(const String& functionName, const String& scriptName, unsigned lineNumber, unsigned column)
+ScriptCallFrame::ScriptCallFrame(const String& functionName, const String& scriptId, const String& scriptName, unsigned lineNumber, unsigned column)
: m_functionName(functionName)
+ , m_scriptId(scriptId)
, m_scriptName(scriptName)
, m_lineNumber(lineNumber)
, m_column(column)
@@ -48,6 +49,7 @@ ScriptCallFrame::~ScriptCallFrame()
bool ScriptCallFrame::isEqual(const ScriptCallFrame& o) const
{
return m_functionName == o.m_functionName
+ && m_scriptId == o.m_scriptId
&& m_scriptName == o.m_scriptName
&& m_lineNumber == o.m_lineNumber;
}
@@ -56,6 +58,7 @@ PassRefPtr<TypeBuilder::Console::CallFrame> ScriptCallFrame::buildInspectorObjec
{
return TypeBuilder::Console::CallFrame::create()
.setFunctionName(m_functionName)
+ .setScriptId(m_scriptId)
.setUrl(m_scriptName)
.setLineNumber(m_lineNumber)
.setColumnNumber(m_column)
« no previous file with comments | « Source/core/inspector/ScriptCallFrame.h ('k') | Source/devtools/front_end/ConsoleMessage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698