[GeometryInterface] Add rotateAxisAngle*(x,y,z,angle) function.

[GeometryInterface] Add rotateAxisAngle*(x,y,z,angle) function.

return a result matrix which rotates on
an axis of given vector(x,y,z) as angle.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself

BUG=388780, 645883
Committed: https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03
Cr-Commit-Position: refs/heads/master@{#425585}

[Hwanseung Lee, 2016-09-24 15:35:08]

Description was changed from

==========
[GeometryInterface] add rotateAxisAngle*(x,y,z,angle) function.

return a result matrix which rotates on
an axis of given vector(x,y,z) as angle.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself

BUG=388780, 645883
==========

to

==========
[GeometryInterface] add rotateAxisAngle*(x,y,z,angle) function.

return a result matrix which rotates on
an axis of given vector(x,y,z) as angle.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself

BUG=388780, 645883
==========

[Hwanseung Lee, 2016-09-24 15:35:09]

hs1217.lee@samsung.com changed reviewers:
+ dominicc@chromium.org, jinho.bang@samsung.com

[Hwanseung Lee, 2016-09-24 15:36:30]

@dominicc, zino
Please take a look. thank you.

[Hwanseung Lee, 2016-09-24 16:12:42]

Description was changed from

==========
[GeometryInterface] add rotateAxisAngle*(x,y,z,angle) function.

return a result matrix which rotates on
an axis of given vector(x,y,z) as angle.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself

BUG=388780, 645883
==========

to

==========
[GeometryInterface] Add rotateAxisAngle*(x,y,z,angle) function.

return a result matrix which rotates on
an axis of given vector(x,y,z) as angle.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself

BUG=388780, 645883
==========

[zino, 2016-09-24 17:38:21]

https://codereview.chromium.org/2365153002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html
(right):

https://codereview.chromium.org/2365153002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:74:
var matrix2d = initDomMatrixFor2DTest();
Let's use new DOMMatrix([arrays]) after landing your patch:
https://codereview.chromium.org/2370613002/

[Hwanseung Lee, 2016-09-25 00:50:54]

https://codereview.chromium.org/2365153002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html
(right):

https://codereview.chromium.org/2365153002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:74:
var matrix2d = initDomMatrixFor2DTest();
On 2016/09/24 17:38:20, zino wrote:
> Let's use new DOMMatrix([arrays]) after landing your patch:
> https://codereview.chromium.org/2370613002/

i added comment about TODO.
if this CL merged first than numberSequnce CL, i will work additionally at next
CL.
otherwise, i will rebase this code.

[dominicc (has gone to gerrit), 2016-09-28 08:16:07]

Sorry I was a bit slow with this.

One thing that's a teeny bit unsatisfying about these tests is you're basically
testing one implementation of rotation matrices in JavaScript against another in
C++.

What do you think about some tests which do +/- 90 degree rotations and encode
the literal rotation matrix? Those should be easy to specify by hand, right?

And then keep some of these getRotationMatrix tests because a few more tests is
nice anyway.

https://codereview.chromium.org/2365153002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html
(right):

https://codereview.chromium.org/2365153002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:17:
if(length != 0) {
Space before (

Maybe if (length) is more succinct?

https://codereview.chromium.org/2365153002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:25:
var alpha_in_radian = deg2rad(alpha_in_degrees / 2);
radian -> radians

[Hwanseung Lee, 2016-09-28 16:20:56]

@dominicc 
PTAL.
i add some test.
it is to rotate +90 and -90 and then compare with init matrix.
i wish that tests will be satisfy your expect.
thank you.

https://codereview.chromium.org/2365153002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html
(right):

https://codereview.chromium.org/2365153002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:17:
if(length != 0) {
On 2016/09/28 08:16:06, dominicc wrote:
> Space before (
> 
> Maybe if (length) is more succinct?

Done.

https://codereview.chromium.org/2365153002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:25:
var alpha_in_radian = deg2rad(alpha_in_degrees / 2);
On 2016/09/28 08:16:06, dominicc wrote:
> radian -> radians

Done.

[zino, 2016-09-29 10:09:58]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 10:10:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zino, 2016-09-29 12:36:01]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 12:36:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 13:58:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 13:58:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[zino, 2016-09-29 17:02:44]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 17:03:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zino, 2016-09-29 17:03:56]

looks good to me but please wait for dominic@'s review.

[Hwanseung Lee, 2016-09-29 17:54:29]

@dominicc, zino.
PTAL.

if this patch-set look good to you,
could you review New CL immediately? 
i upload new CL about setMatrixValue() function.
(https://codereview.chromium.org/2380713004/)
new CL based on this CL.

actually i have been participated hackathon about open-source this week in our
country.
so i am competing with friends about score.
1 point is 1 merged CL.

thank you.

[commit-bot: I haz the power, 2016-09-29 18:38:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 18:38:04]

Dry run: This issue passed the CQ dry run.

[zino, 2016-10-04 16:24:51]

lgtm in my side.

dominic@ gentle ping :)

[dominicc (has gone to gerrit), 2016-10-05 04:29:52]

With the 90 and 180 degree rotation tests, I was thinking you could initialize
the matrix with a unique x-axis value and assert that value appears on the
y-axis after 90 degree rotation around z for example.

Rotating n-degrees and back is also somewhat interesting but wasn't exactly what
I had in mind.

https://codereview.chromium.org/2365153002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html
(right):

https://codereview.chromium.org/2365153002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:330:
}, "DOMMatrix 3d - rotateAxisAngleSelf() - do rotate +90,90");
-90?

[Hwanseung Lee, 2016-10-05 16:07:57]

@dominicc
PTAL.
i did add tests at last of test file.
i think it will be satisfy your mind.
could you review again?

https://codereview.chromium.org/2365153002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html
(right):

https://codereview.chromium.org/2365153002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:330:
}, "DOMMatrix 3d - rotateAxisAngleSelf() - do rotate +90,90");
On 2016/10/05 04:29:52, dominicc wrote:
> -90?

Done.

[dominicc (has gone to gerrit), 2016-10-14 08:21:37]

Sorry for the slow reply. One more idea to make these tests more readable.

https://codereview.chromium.org/2365153002/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html
(right):

https://codereview.chromium.org/2365153002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:55:
assert_array_almost_equals(matrix2d.toFloat64Array(),
expectedMatrix.toFloat64Array());
All? Almost all? of the calls to assert_array_almost_equal do toFloat64Array on
both their arguments. What do you think about adding
assert_matrix_almost_equal(m1, m2) instead/as well? It would make the call sites
much easier to read...

https://codereview.chromium.org/2365153002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:340:
test(() => {
I like the way this test swings around each axis, it's very easy to follow.

[Hwanseung Lee, 2016-10-15 01:42:09]

@dominicc

i did add assert_matrix_almost_equal function.
could you review again?

https://codereview.chromium.org/2365153002/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html
(right):

https://codereview.chromium.org/2365153002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:55:
assert_array_almost_equals(matrix2d.toFloat64Array(),
expectedMatrix.toFloat64Array());
On 2016/10/14 08:21:37, dominicc wrote:
> All? Almost all? of the calls to assert_array_almost_equal do toFloat64Array
on
> both their arguments. What do you think about adding
> assert_matrix_almost_equal(m1, m2) instead/as well? It would make the call
sites
> much easier to read...

Done.

[dominicc (has gone to gerrit), 2016-10-16 08:49:22]

lgtm

[Hwanseung Lee, 2016-10-16 08:51:04]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2016-10-16 08:51:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
jinho.bang@samsung.com
Link to the patchset: https://codereview.chromium.org/2365153002/#ps160001
(title: "update test.")

[commit-bot: I haz the power, 2016-10-16 08:51:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-16 10:10:02]

Description was changed from

==========
[GeometryInterface] Add rotateAxisAngle*(x,y,z,angle) function.

return a result matrix which rotates on
an axis of given vector(x,y,z) as angle.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself

BUG=388780, 645883
==========

to

==========
[GeometryInterface] Add rotateAxisAngle*(x,y,z,angle) function.

return a result matrix which rotates on
an axis of given vector(x,y,z) as angle.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself

BUG=388780, 645883
==========

[commit-bot: I haz the power, 2016-10-16 10:10:03]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-10-16 10:12:07]

Description was changed from

==========
[GeometryInterface] Add rotateAxisAngle*(x,y,z,angle) function.

return a result matrix which rotates on
an axis of given vector(x,y,z) as angle.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself

BUG=388780, 645883
==========

to

==========
[GeometryInterface] Add rotateAxisAngle*(x,y,z,angle) function.

return a result matrix which rotates on
an axis of given vector(x,y,z) as angle.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself

BUG=388780, 645883

Committed: https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03
Cr-Commit-Position: refs/heads/master@{#425585}
==========

[commit-bot: I haz the power, 2016-10-16 10:12:08]

Patchset 9 (id:??) landed as
https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03
Cr-Commit-Position: refs/heads/master@{#425585}