Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 23636011: Add a GrGpuGL reference for GrGLProgram/GrGLUniformManager (Closed)

Created:
7 years, 3 months ago by Chris Dalton
Modified:
7 years, 3 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add a GrGpuGL reference for GrGLProgram/GrGLUniformManager Updates GrGLProgram and GrGLUniformManager to keep a GrGpuGL reference instead of one for GrGLContextInfo. No change in functionality, this is in preparation to support fixed function GL calls for vertexless shaders. Committed: http://code.google.com/p/skia/source/detail?r=11111

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -72 lines) Patch
M src/gpu/gl/GrGLProgram.h View 5 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 16 chunks +24 lines, -27 lines 0 comments Download
M src/gpu/gl/GrGLUniformManager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLUniformManager.cpp View 15 chunks +28 lines, -27 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 3 chunks +3 lines, -2 lines 1 comment Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Dalton
https://codereview.chromium.org/23636011/diff/1/src/gpu/gl/GrGpuGL.h File src/gpu/gl/GrGpuGL.h (right): https://codereview.chromium.org/23636011/diff/1/src/gpu/gl/GrGpuGL.h#newcode34 src/gpu/gl/GrGpuGL.h:34: const GrGLContextInfo& ctxInfo() const { return fGLContext.info(); } We ...
7 years, 3 months ago (2013-09-05 05:29:24 UTC) #1
bsalomon
On 2013/09/05 05:29:24, cdalton wrote: > https://codereview.chromium.org/23636011/diff/1/src/gpu/gl/GrGpuGL.h > File src/gpu/gl/GrGpuGL.h (right): > > https://codereview.chromium.org/23636011/diff/1/src/gpu/gl/GrGpuGL.h#newcode34 > ...
7 years, 3 months ago (2013-09-05 12:59:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/23636011/1
7 years, 3 months ago (2013-09-05 12:59:11 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 18:28:31 UTC) #4
Message was sent while issue was closed.
Change committed as 11111

Powered by Google App Engine
This is Rietveld 408576698