chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java - Issue 2362673005: [Android] Change default search engine setting page to full screen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

Issue 2362673005: [Android] Change default search engine setting page to full screen (Closed)

Patch Set: update based on Ian's new comments and Rolfe's suggestions for UI. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout/search_engine_layout.xml ('K') | « chrome/android/java/res/xml/main_preferences.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

index b133ced8155b9dc2e209054c8865c0d24f464d7c..1284d9bbf4534685d8408c6750b474655fe82846 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

@@ -8,7 +8,6 @@ import android.content.Context;

import android.content.Intent;

import android.net.Uri;

import android.os.Build;

-import android.os.Bundle;

import android.text.SpannableString;

import android.text.style.TypefaceSpan;

import android.view.View;

@@ -16,9 +15,8 @@ import android.view.View;

import org.chromium.base.ContextUtils;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.device.DeviceClassManager;

-import org.chromium.chrome.browser.preferences.MainPreferences;

-import org.chromium.chrome.browser.preferences.Preferences;

import org.chromium.chrome.browser.preferences.PreferencesLauncher;

+import org.chromium.chrome.browser.preferences.SearchEnginePreferences;

import org.chromium.chrome.browser.search_engines.TemplateUrlService;

import org.chromium.chrome.browser.snackbar.Snackbar;

import org.chromium.chrome.browser.snackbar.SnackbarManager;

@@ -132,10 +130,8 @@ public class GeolocationSnackbarController implements SnackbarController {

UiUtils.hideKeyboard(view);

Context context = view.getContext();

- Intent intent = PreferencesLauncher.createIntentForSettingsPage(context, null);

- Bundle fragmentArgs = new Bundle();

- fragmentArgs.putBoolean(MainPreferences.EXTRA_SHOW_SEARCH_ENGINE_PICKER, true);

- intent.putExtra(Preferences.EXTRA_SHOW_FRAGMENT_ARGUMENTS, fragmentArgs);

+ Intent intent = PreferencesLauncher.createIntentForSettingsPage(

+ context, SearchEnginePreferences.class.getName());

context.startActivity(intent);

}