chrome/android/java/res/xml/main_preferences.xml - Issue 2362673005: [Android] Change default search engine setting page to full screen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/xml/main_preferences.xml

Issue 2362673005: [Android] Change default search engine setting page to full screen (Closed)

Patch Set: update based on Ian's new comments and Rolfe's suggestions for UI. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/xml/main_preferences.xml

diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/java/res/xml/main_preferences.xml

index b3dae2aed8a59be8729e67f4e8c562e3873b633a..aa08deeace764dc7dcb8b2bb4c2924c09bb082b3 100644

--- a/chrome/android/java/res/xml/main_preferences.xml

+++ b/chrome/android/java/res/xml/main_preferences.xml

@@ -11,7 +11,8 @@

<PreferenceCategory

android:title="@string/prefs_section_basics"/>

- <org.chromium.chrome.browser.preferences.SearchEnginePreference

+ <org.chromium.chrome.browser.preferences.ChromeBasePreference

+ android:fragment="org.chromium.chrome.browser.preferences.SearchEnginePreferences"

android:key="search_engine"

android:title="@string/prefs_search_engine"/>

<org.chromium.chrome.browser.preferences.ChromeBasePreference