Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: chrome/android/java/res/layout/search_engine_layout.xml

Issue 2362673005: [Android] Change default search engine setting page to full screen (Closed)
Patch Set: update based on Ian's new comments and Rolfe's suggestions for UI. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/search_engine_layout.xml
diff --git a/chrome/android/java/res/layout/search_engine_layout.xml b/chrome/android/java/res/layout/search_engine_layout.xml
new file mode 100644
index 0000000000000000000000000000000000000000..56d81c459764024bc44062d6a1e5db646696ab8b
--- /dev/null
+++ b/chrome/android/java/res/layout/search_engine_layout.xml
@@ -0,0 +1,64 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<LinearLayout
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:chrome="http://schemas.android.com/apk/res-auto"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:paddingTop="6dp"
+ android:orientation="vertical">
+
+ <ListView
+ android:id="@android:id/list"
+ android:layout_width="match_parent"
+ android:layout_height="0dp"
+ android:layout_weight="1"/>
+
+ <View
+ android:id="@+id/bottombar_divider"
+ android:layout_width="match_parent"
+ android:layout_height="1dp"
+ android:layout_marginTop="-1dp"
Ian Wen 2016/09/26 18:32:01 Remove #24.
ltian 2016/09/26 18:46:44 Done.
+ android:background="@drawable/toolbar_shadow_normal"
+ android:scaleY="-1"
+ android:visibility="invisible" />
Ian Wen 2016/09/26 18:32:01 Switch to gone.
ltian 2016/09/26 18:46:44 Done.
ltian 2016/09/26 21:01:22 It seems after changing to "gone", when orientatio
+
+ <LinearLayout
+ android:layout_width="match_parent"
+ android:layout_height="56dp"
+ android:orientation="horizontal"
+ android:gravity="end"
+ android:paddingStart="6dp"
+ android:paddingEnd="6dp">
+
+ <Button
+ android:id="@+id/cancel_button"
+ style="@style/ButtonCompatBorderless"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:textColor="@color/light_active_color"
+ android:text="@string/cancel"
+ android:textAllCaps="true"
+ android:textSize="14sp"
+ android:layout_marginEnd="16dp"
+ android:layout_gravity="center_vertical"/>
+
+ <org.chromium.ui.widget.ButtonCompat
+ android:id="@+id/save_button"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:textColor="@android:color/white"
+ android:text="@string/save"
+ android:textAllCaps="true"
+ android:textSize="14sp"
+ android:layout_marginEnd="8dp"
+ chrome:buttonColor="@color/light_active_color"
+ chrome:buttonRaised="false"
+ android:layout_gravity="center_vertical"/>
+
+ </LinearLayout>
+
+</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698