Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2962)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java

Issue 2362673005: [Android] Change default search engine setting page to full screen (Closed)
Patch Set: update based on Ian's new comments and Rolfe's suggestions for UI. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java
new file mode 100644
index 0000000000000000000000000000000000000000..90be22500aebc8627910012f51f5df7e7df5b8a6
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java
@@ -0,0 +1,98 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.preferences;
+
+import android.os.Bundle;
+import android.preference.PreferenceFragment;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.View.OnLayoutChangeListener;
+import android.view.ViewGroup;
+import android.widget.ListView;
+
+import org.chromium.chrome.R;
+import org.chromium.chrome.browser.search_engines.TemplateUrlService;
+
+/**
+* A preference fragment for selecting a default search engine.
+*/
+public class SearchEnginePreferences extends PreferenceFragment
+ implements View.OnClickListener, SearchEngineAdapter.SelectSearchEngineCallback,
+ OnLayoutChangeListener {
+ static final String PREF_SEARCH_ENGINE = "search_engine";
+
+ private ListView mListView;
+ private View mCancelButton;
+ private View mSaveButton;
+ private View mDivider;
+
+ private SearchEngineAdapter mSearchEngineAdapter;
+ private int mSelectedIndex;
+
+ @Override
+ public void onCreate(Bundle savedInstanceState) {
+ super.onCreate(savedInstanceState);
+ getActivity().setTitle(R.string.prefs_search_engine);
+ mSearchEngineAdapter = new SearchEngineAdapter(getActivity(), this);
+ }
+
+ @Override
+ public View onCreateView(
+ LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
+ View view = inflater.inflate(R.layout.search_engine_layout, container, false);
+ mListView = (ListView) view.findViewById(android.R.id.list);
+ mListView.setAdapter(mSearchEngineAdapter);
+ mListView.setDivider(null);
+ mListView.addOnLayoutChangeListener(this);
+ mCancelButton = view.findViewById(R.id.cancel_button);
+ mCancelButton.setOnClickListener(this);
+ mSaveButton = view.findViewById(R.id.save_button);
+ mSaveButton.setOnClickListener(this);
+ mDivider = view.findViewById(R.id.bottombar_divider);
+ return view;
+ }
+
+ @Override
+ public void onActivityCreated(Bundle savedInstanceState) {
+ super.onActivityCreated(savedInstanceState);
+ }
+
+ @Override
+ public void onClick(View v) {
+ if (v == mCancelButton) {
+ getActivity().finish();
+ } else if (v == mSaveButton) {
+ TemplateUrlService.getInstance().setSearchEngine(mSelectedIndex);
+ getActivity().finish();
+ }
+ }
+
+ @Override
+ public void currentSearchEngineDetermined(int selectedIndex) {
+ mSelectedIndex = selectedIndex;
+ }
+
+ @Override
+ public void onResume() {
+ super.onResume();
+ mSearchEngineAdapter.notifyDataSetChanged();
Ian Wen 2016/09/26 18:32:01 Remove #80.
ltian 2016/09/26 18:46:44 Done.
+ }
+
+ public void updateBottombarDivider() {
+ if (mListView.getLastVisiblePosition() == mSearchEngineAdapter.getCount() - 1) {
Ian Wen 2016/09/26 18:32:01 Add comment: Display the divider if the listview
ltian 2016/09/26 18:46:44 Done.
+ mDivider.setVisibility(View.INVISIBLE);
Ian Wen 2016/09/26 18:32:01 To Gone.
ltian 2016/09/26 18:46:44 Done.
ltian 2016/09/26 21:01:22 Same issue for "View.GONE" as it is in search_engi
+ } else {
+ mDivider.setVisibility(View.VISIBLE);
+ }
+ }
+
+ @Override
+ public void onLayoutChange(View v, int left, int top, int right, int bottom, int oldLeft,
+ int oldTop, int oldRight, int oldBottom) {
+ if (v == mListView) {
+ updateBottombarDivider();
+ }
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698