chrome/android/java/res/layout/search_engine_layout.xml - Issue 2362673005: [Android] Change default search engine setting page to full screen

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/search_engine_layout.xml

Issue 2362673005: [Android] Change default search engine setting page to full screen (Closed)

Patch Set: update based on Ian's new comments and Rolfe's suggestions for UI. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/search_engine.xml ('k') | chrome/android/java/res/xml/main_preferences.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	9 android:layout_width="match_parent"

	10 android:layout_height="match_parent"

	11 android:paddingTop="6dp"

	12 android:orientation="vertical">

	13

	14 <ListView

	15 android:id="@android:id/list"

	16 android:layout_width="match_parent"

	17 android:layout_height="0dp"

	18 android:layout_weight="1"/>

	19

	20 <View

	21 android:id="@+id/bottombar_divider"

	22 android:layout_width="match_parent"

	23 android:layout_height="1dp"

	24 android:layout_marginTop="-1dp"
	Ian Wen 2016/09/26 18:32:01 Remove #24. Remove #24. ltian 2016/09/26 18:46:44 Done. Show quoted text On 2016/09/26 18:32:01, Ian Wen wrote: > Remove #24. Done.
	25 android:background="@drawable/toolbar_shadow_normal"

	26 android:scaleY="-1"

	27 android:visibility="invisible" />
	Ian Wen 2016/09/26 18:32:01 Switch to gone. Switch to gone. ltian 2016/09/26 18:46:44 Done. Show quoted text On 2016/09/26 18:32:01, Ian Wen wrote: > Switch to gone. Done. ltian 2016/09/26 21:01:22 It seems after changing to "gone", when orientatio Show quoted text On 2016/09/26 18:46:44, ltian wrote: > On 2016/09/26 18:32:01, Ian Wen wrote: > > Switch to gone. > > Done. It seems after changing to "gone", when orientation is changed and in landscape layout, listview is larger than its viewport while in portrait layout, it is not, the divider is not displayed correctly.
	28

	29 <LinearLayout

	30 android:layout_width="match_parent"

	31 android:layout_height="56dp"

	32 android:orientation="horizontal"

	33 android:gravity="end"

	34 android:paddingStart="6dp"

	35 android:paddingEnd="6dp">

	36

	37 <Button

	38 android:id="@+id/cancel_button"

	39 style="@style/ButtonCompatBorderless"

	40 android:layout_width="wrap_content"

	41 android:layout_height="wrap_content"

	42 android:textColor="@color/light_active_color"

	43 android:text="@string/cancel"

	44 android:textAllCaps="true"

	45 android:textSize="14sp"

	46 android:layout_marginEnd="16dp"

	47 android:layout_gravity="center_vertical"/>

	48

	49 <org.chromium.ui.widget.ButtonCompat

	50 android:id="@+id/save_button"

	51 android:layout_width="wrap_content"

	52 android:layout_height="wrap_content"

	53 android:textColor="@android:color/white"

	54 android:text="@string/save"

	55 android:textAllCaps="true"

	56 android:textSize="14sp"

	57 android:layout_marginEnd="8dp"

	58 chrome:buttonColor="@color/light_active_color"

	59 chrome:buttonRaised="false"

	60 android:layout_gravity="center_vertical"/>

	61

	62 </LinearLayout>

	63

	64 </LinearLayout>

OLD	NEW