Issue 23596006: Revise SVD code to remove arctangents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23596006: Revise SVD code to remove arctangents. (Closed)

Created:
7 years, 3 months ago by jvanverth1

Modified:
7 years, 3 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revise SVD code to remove arctangents. Also added bench for timing matrix decomposition. Committed: http://code.google.com/p/skia/source/detail?r=11066

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+202 lines, -205 lines)			Patch
M	bench/MatrixBench.cpp	View	1	3 chunks	+31 lines, -0 lines	0 comments	Download
M	src/core/SkMatrix.cpp	View		2 chunks	+80 lines, -63 lines	0 comments	Download
M	src/core/SkMatrixUtils.h	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	tests/Matrix44Test.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/MatrixTest.cpp	View		4 chunks	+81 lines, -132 lines	0 comments	Download

Total messages: 4 (0 generated)

jvanverth1

So this is the matrix-friendly vs. angle-friendly version of SVD. It's considerably faster if your ...

7 years, 3 months ago (2013-09-03 17:47:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/23596006/3001

7 years, 3 months ago (2013-09-03 18:37:58 UTC) #3

Message was sent while issue was closed.

Change committed as 11066