Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2210)

Unified Diff: chrome/browser/google_apis/drive_api_requests.cc

Issue 23549003: Refactor GetChangelistRequest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google_apis/drive_api_requests.cc
diff --git a/chrome/browser/google_apis/drive_api_requests.cc b/chrome/browser/google_apis/drive_api_requests.cc
index fed7f8e59ea7cdd417f6ce324e87fb575429acfe..ee1a9c7a08adfae33bc1961263a2b26ad8d8e094 100644
--- a/chrome/browser/google_apis/drive_api_requests.cc
+++ b/chrome/browser/google_apis/drive_api_requests.cc
@@ -114,30 +114,6 @@ void ParseFileResourceWithUploadRangeAndRun(
} // namespace
-//============================ GetChangelistRequest ==========================
-
-GetChangelistRequest::GetChangelistRequest(
- RequestSender* sender,
- const DriveApiUrlGenerator& url_generator,
- bool include_deleted,
- int64 start_changestamp,
- int max_results,
- const GetDataCallback& callback)
- : GetDataRequest(sender, callback),
- url_generator_(url_generator),
- include_deleted_(include_deleted),
- start_changestamp_(start_changestamp),
- max_results_(max_results) {
- DCHECK(!callback.is_null());
-}
-
-GetChangelistRequest::~GetChangelistRequest() {}
-
-GURL GetChangelistRequest::GetURL() const {
- return url_generator_.GetChangelistUrl(
- include_deleted_, start_changestamp_, max_results_);
-}
-
namespace drive {
//=============================== FilesGetRequest =============================
@@ -267,6 +243,31 @@ GURL AboutGetRequest::GetURL() const {
return url_generator_.GetAboutGetUrl();
}
+//============================ ChangesListRequest ===========================
+
+ChangesListRequest::ChangesListRequest(
+ RequestSender* sender,
+ const DriveApiUrlGenerator& url_generator,
+ const ChangeListCallback& callback)
+ : GetDataRequest(
+ sender,
+ base::Bind(&ParseJsonOnBlockingPoolAndRun<ChangeList>,
+ make_scoped_refptr(sender->blocking_task_runner()),
+ callback)),
+ url_generator_(url_generator),
+ include_deleted_(true),
+ max_results_(100),
+ start_change_id_(0) {
+ DCHECK(!callback.is_null());
+}
+
+ChangesListRequest::~ChangesListRequest() {}
+
+GURL ChangesListRequest::GetURL() const {
+ return url_generator_.GetChangesListUrl(
+ include_deleted_, max_results_, page_token_, start_change_id_);
+}
+
//============================== AppsListRequest ===========================
AppsListRequest::AppsListRequest(
« no previous file with comments | « chrome/browser/google_apis/drive_api_requests.h ('k') | chrome/browser/google_apis/drive_api_requests_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698