Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1923)

Unified Diff: chrome/browser/google_apis/drive_api_requests_unittest.cc

Issue 23549003: Refactor GetChangelistRequest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google_apis/drive_api_requests_unittest.cc
diff --git a/chrome/browser/google_apis/drive_api_requests_unittest.cc b/chrome/browser/google_apis/drive_api_requests_unittest.cc
index 0ee0223f3c10205d6cf2ff77415f9a4982ccdb63..3f2443f0aab760397396fbcf088890045c73ae42 100644
--- a/chrome/browser/google_apis/drive_api_requests_unittest.cc
+++ b/chrome/browser/google_apis/drive_api_requests_unittest.cc
@@ -482,32 +482,31 @@ TEST_F(DriveApiRequestsTest, AppsListRequest) {
EXPECT_TRUE(app_list);
}
-TEST_F(DriveApiRequestsTest, GetChangelistRequest) {
+TEST_F(DriveApiRequestsTest, ChangesListRequest) {
// Set an expected data file containing valid result.
expected_data_file_path_ = test_util::GetTestFilePath(
"drive/changelist.json");
GDataErrorCode error = GDATA_OTHER_ERROR;
- scoped_ptr<base::Value> result;
+ scoped_ptr<ChangeList> result;
{
base::RunLoop run_loop;
- GetChangelistRequest* request = new GetChangelistRequest(
- request_sender_.get(),
- *url_generator_,
- true, // include deleted
- 100, // start changestamp
- 500, // max results
+ drive::ChangesListRequest* request = new drive::ChangesListRequest(
+ request_sender_.get(), *url_generator_,
test_util::CreateQuitCallback(
&run_loop,
test_util::CreateCopyResultCallback(&error, &result)));
+ request->set_include_deleted(true);
+ request->set_start_change_id(100);
+ request->set_max_results(500);
request_sender_->StartRequestWithRetry(request);
run_loop.Run();
}
EXPECT_EQ(HTTP_SUCCESS, error);
EXPECT_EQ(net::test_server::METHOD_GET, http_request_.method);
- EXPECT_EQ("/drive/v2/changes?startChangeId=100&maxResults=500",
+ EXPECT_EQ("/drive/v2/changes?maxResults=500&startChangeId=100",
http_request_.relative_url);
EXPECT_TRUE(result);
}
« no previous file with comments | « chrome/browser/google_apis/drive_api_requests.cc ('k') | chrome/browser/google_apis/drive_api_url_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698