Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: chrome/browser/google_apis/drive_api_requests.cc

Issue 23549003: Refactor GetChangelistRequest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/google_apis/drive_api_requests.h" 5 #include "chrome/browser/google_apis/drive_api_requests.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/json/json_writer.h" 9 #include "base/json/json_writer.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 scoped_ptr<FileResource>()); 107 scoped_ptr<FileResource>());
108 return; 108 return;
109 } 109 }
110 } 110 }
111 111
112 callback.Run(response, file_resource.Pass()); 112 callback.Run(response, file_resource.Pass());
113 } 113 }
114 114
115 } // namespace 115 } // namespace
116 116
117 //============================ GetChangelistRequest ==========================
118
119 GetChangelistRequest::GetChangelistRequest(
120 RequestSender* sender,
121 const DriveApiUrlGenerator& url_generator,
122 bool include_deleted,
123 int64 start_changestamp,
124 int max_results,
125 const GetDataCallback& callback)
126 : GetDataRequest(sender, callback),
127 url_generator_(url_generator),
128 include_deleted_(include_deleted),
129 start_changestamp_(start_changestamp),
130 max_results_(max_results) {
131 DCHECK(!callback.is_null());
132 }
133
134 GetChangelistRequest::~GetChangelistRequest() {}
135
136 GURL GetChangelistRequest::GetURL() const {
137 return url_generator_.GetChangelistUrl(
138 include_deleted_, start_changestamp_, max_results_);
139 }
140
141 namespace drive { 117 namespace drive {
142 118
143 //=============================== FilesGetRequest ============================= 119 //=============================== FilesGetRequest =============================
144 120
145 FilesGetRequest::FilesGetRequest( 121 FilesGetRequest::FilesGetRequest(
146 RequestSender* sender, 122 RequestSender* sender,
147 const DriveApiUrlGenerator& url_generator, 123 const DriveApiUrlGenerator& url_generator,
148 const FileResourceCallback& callback) 124 const FileResourceCallback& callback)
149 : GetDataRequest(sender, 125 : GetDataRequest(sender,
150 base::Bind(&ParseJsonAndRun<FileResource>, callback)), 126 base::Bind(&ParseJsonAndRun<FileResource>, callback)),
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 url_generator_(url_generator) { 236 url_generator_(url_generator) {
261 DCHECK(!callback.is_null()); 237 DCHECK(!callback.is_null());
262 } 238 }
263 239
264 AboutGetRequest::~AboutGetRequest() {} 240 AboutGetRequest::~AboutGetRequest() {}
265 241
266 GURL AboutGetRequest::GetURL() const { 242 GURL AboutGetRequest::GetURL() const {
267 return url_generator_.GetAboutGetUrl(); 243 return url_generator_.GetAboutGetUrl();
268 } 244 }
269 245
246 //============================ ChangesListRequest ===========================
247
248 ChangesListRequest::ChangesListRequest(
249 RequestSender* sender,
250 const DriveApiUrlGenerator& url_generator,
251 const ChangeListCallback& callback)
252 : GetDataRequest(
253 sender,
254 base::Bind(&ParseJsonOnBlockingPoolAndRun<ChangeList>,
255 make_scoped_refptr(sender->blocking_task_runner()),
256 callback)),
257 url_generator_(url_generator),
258 include_deleted_(true),
259 max_results_(100),
260 start_change_id_(0) {
261 DCHECK(!callback.is_null());
262 }
263
264 ChangesListRequest::~ChangesListRequest() {}
265
266 GURL ChangesListRequest::GetURL() const {
267 return url_generator_.GetChangesListUrl(
268 include_deleted_, max_results_, page_token_, start_change_id_);
269 }
270
270 //============================== AppsListRequest =========================== 271 //============================== AppsListRequest ===========================
271 272
272 AppsListRequest::AppsListRequest( 273 AppsListRequest::AppsListRequest(
273 RequestSender* sender, 274 RequestSender* sender,
274 const DriveApiUrlGenerator& url_generator, 275 const DriveApiUrlGenerator& url_generator,
275 const AppListCallback& callback) 276 const AppListCallback& callback)
276 : GetDataRequest(sender, 277 : GetDataRequest(sender,
277 base::Bind(&ParseJsonAndRun<AppList>, callback)), 278 base::Bind(&ParseJsonAndRun<AppList>, callback)),
278 url_generator_(url_generator) { 279 url_generator_(url_generator) {
279 DCHECK(!callback.is_null()); 280 DCHECK(!callback.is_null());
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 progress_callback, 780 progress_callback,
780 url_generator.GenerateDownloadFileUrl(resource_id), 781 url_generator.GenerateDownloadFileUrl(resource_id),
781 output_file_path) { 782 output_file_path) {
782 } 783 }
783 784
784 DownloadFileRequest::~DownloadFileRequest() { 785 DownloadFileRequest::~DownloadFileRequest() {
785 } 786 }
786 787
787 } // namespace drive 788 } // namespace drive
788 } // namespace google_apis 789 } // namespace google_apis
OLDNEW
« no previous file with comments | « chrome/browser/google_apis/drive_api_requests.h ('k') | chrome/browser/google_apis/drive_api_requests_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698