Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 23549003: Refactor GetChangelistRequest. (Closed)

Created:
7 years, 3 months ago by hidehiko
Modified:
7 years, 3 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Refactor GetChangelistRequest. To adapt Drive API v2 request, this CL refactors GetChangelistRequest to ChangesListRequest. BUG=277253, 275233 TEST=Ran unit_tests and tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -151 lines) Patch
M chrome/browser/drive/drive_api_service.cc View 5 chunks +43 lines, -21 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests.h View 3 chunks +53 lines, -33 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests.cc View 2 chunks +25 lines, -24 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests_unittest.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/google_apis/drive_api_url_generator.h View 2 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/google_apis/drive_api_url_generator.cc View 2 chunks +28 lines, -19 lines 0 comments Download
M chrome/browser/google_apis/drive_api_url_generator_unittest.cc View 2 chunks +70 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 3 months ago (2013-08-28 09:54:04 UTC) #1
kinaba
lgtm
7 years, 3 months ago (2013-08-29 04:03:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23549003/1
7 years, 3 months ago (2013-08-29 09:33:23 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 11:53:08 UTC) #4
Message was sent while issue was closed.
Change committed as 220273

Powered by Google App Engine
This is Rietveld 408576698