Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23506040: Add ethernet to ONC validation and Shill translation. (Closed)

Created:
7 years, 3 months ago by pneubeck (no reviews)
Modified:
7 years, 3 months ago
Reviewers:
armansito
CC:
chromium-reviews, extensions-reviews_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Add ethernet to ONC validation and Shill translation. BUG=126870 (for networking_private_api_nonchromeos.cc) TBR=gspencer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223630

Patch Set 1 #

Patch Set 2 : Tiny cleanup. #

Patch Set 3 : Fixed networkingPrivate api test on non-chromeos. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -21 lines) Patch
M chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/networking/test.js View 1 chunk +4 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_signature.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_translator_onc_to_shill.cc View 4 chunks +23 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 1 4 chunks +27 lines, -6 lines 0 comments Download
M chromeos/network/onc/onc_translator_unittest.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_validator_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
A + chromeos/test/data/network/ethernet.onc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chromeos/test/data/network/ethernet_with_eap.onc View 1 chunk +24 lines, -0 lines 0 comments Download
A chromeos/test/data/network/ethernet_with_eap_and_cert_pems.onc View 1 chunk +24 lines, -0 lines 0 comments Download
D chromeos/test/data/network/managed_ethernet.onc View 1 chunk +0 lines, -7 lines 0 comments Download
A chromeos/test/data/network/shill_ethernet_with_eap.json View 1 chunk +8 lines, -0 lines 0 comments Download
A chromeos/test/data/network/translation_of_shill_ethernet.onc View 1 chunk +8 lines, -0 lines 0 comments Download
A chromeos/test/data/network/translation_of_shill_ethernet_with_eap.onc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pneubeck (no reviews)
Please take a look.
7 years, 3 months ago (2013-09-14 20:00:03 UTC) #1
armansito
lgtm. Could you later add a functional test for this using the autotest-telemetry harness for ...
7 years, 3 months ago (2013-09-16 21:26:58 UTC) #2
pneubeck (no reviews)
On 2013/09/16 21:26:58, armansito wrote: > lgtm. Could you later add a functional test for ...
7 years, 3 months ago (2013-09-17 08:31:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/23506040/6002
7 years, 3 months ago (2013-09-17 09:15:29 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=168810
7 years, 3 months ago (2013-09-17 12:22:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/23506040/30001
7 years, 3 months ago (2013-09-17 12:38:36 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=25834
7 years, 3 months ago (2013-09-17 12:52:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/23506040/34001
7 years, 3 months ago (2013-09-17 15:06:08 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 3 months ago (2013-09-17 17:28:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/23506040/34001
7 years, 3 months ago (2013-09-17 17:38:48 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 17:40:07 UTC) #11
Message was sent while issue was closed. 
Change committed as 223630

Powered by Google App Engine
This is Rietveld 408576698