chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc - Issue 23506040: Add ethernet to ONC validation and Shill translation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc

Issue 23506040: Add ethernet to ONC validation and Shill translation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed networkingPrivate api test on non-chromeos. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc b/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc

index f50af50ce4b1616b36d73a0af704d058b068dfbc..bc206ada293a3b376d6a71a2c8b82177b705e226 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc

@@ -232,7 +232,10 @@ bool NetworkingPrivateGetVisibleNetworksFunction::RunImpl() {

" \"ConnectionState\": \"Connected\","

" \"GUID\": \"stub_ethernet\","

" \"Name\": \"eth0\","

- " \"Type\": \"Ethernet\""

+ " \"Type\": \"Ethernet\","

+ " \"Ethernet\": {"

+ " \"Authentication\": \"None\""

+ " }"

" },"

" {"

" \"ConnectionState\": \"Connected\","

« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/networking/test.js » ('j') | no next file with comments »