chromeos/network/onc/onc_translator_unittest.cc - Issue 23506040: Add ethernet to ONC validation and Shill translation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_translator_unittest.cc

Issue 23506040: Add ethernet to ONC validation and Shill translation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed networkingPrivate api test on non-chromeos. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_translator_unittest.cc

diff --git a/chromeos/network/onc/onc_translator_unittest.cc b/chromeos/network/onc/onc_translator_unittest.cc

index 6bc7b6adaf282964e23b100dbe1e96ee59e4e48f..12f952f3b3d63d0bf6b692150993e247042b48fa 100644

--- a/chromeos/network/onc/onc_translator_unittest.cc

+++ b/chromeos/network/onc/onc_translator_unittest.cc

@@ -42,7 +42,9 @@ INSTANTIATE_TEST_CASE_P(

ONCTranslatorOncToShillTest,

::testing::Values(

- std::make_pair("managed_ethernet.onc", "shill_ethernet.json"),

+ std::make_pair("ethernet.onc", "shill_ethernet.json"),

+ std::make_pair("ethernet_with_eap_and_cert_pems.onc",

+ "shill_ethernet_with_eap.json"),

std::make_pair("valid_wifi_psk.onc", "shill_wifi_psk.json"),

std::make_pair("wifi_clientcert_with_cert_pems.onc",

"shill_wifi_clientcert.json"),

@@ -86,6 +88,10 @@ INSTANTIATE_TEST_CASE_P(

ONCTranslatorShillToOncTest,

::testing::Values(

+ std::make_pair("shill_ethernet.json",

+ "translation_of_shill_ethernet.onc"),

+ std::make_pair("shill_ethernet_with_eap.json",

+ "translation_of_shill_ethernet_with_eap.onc"),

std::make_pair("shill_wifi_clientcert.json",

"translation_of_shill_wifi_clientcert.onc"),

std::make_pair("shill_wifi_wpa1.json",