chromeos/network/onc/onc_translation_tables.cc - Issue 23506040: Add ethernet to ONC validation and Shill translation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_translation_tables.cc

Issue 23506040: Add ethernet to ONC validation and Shill translation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed networkingPrivate api test on non-chromeos. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_translation_tables.cc

diff --git a/chromeos/network/onc/onc_translation_tables.cc b/chromeos/network/onc/onc_translation_tables.cc

index 8a1b29d2bcf2fe3dac226278816283f564c60c07..0cc2b6b3c3c4c8248d5db989b5c08d1469fae74f 100644

--- a/chromeos/network/onc/onc_translation_tables.cc

+++ b/chromeos/network/onc/onc_translation_tables.cc

@@ -212,7 +212,9 @@ const NestedShillDictionaryEntry nested_shill_dictionaries[] = {

} // namespace

const StringTranslationEntry kNetworkTypeTable[] = {

- { network_type::kEthernet, flimflam::kTypeEthernet },

+ // This mapping is ensured in the translation code.

+ // { network_type::kEthernet, flimflam::kTypeEthernet },

+ // { network_type::kEthernet, shill::kTypeEthernetEap },

{ network_type::kWiFi, flimflam::kTypeWifi },

{ network_type::kCellular, flimflam::kTypeCellular },

{ network_type::kVPN, flimflam::kTypeVPN },