Issue 23330008: Introduce MockResourceConverter to modularize testing of V8VarConverter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23330008: Introduce MockResourceConverter to modularize testing of V8VarConverter (Closed)

Created:
7 years, 4 months ago by raymes

Modified:
7 years, 4 months ago

Reviewers:
teravest

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Introduce MockResourceConverter to modularize testing of V8VarConverter This changes V8VarConverter into a class which has a constructor which is used specifically for testing. It accepts the MessageLoopProxy to run callbacks on and a ResourceConverter (which can be mocked). This allows more modular testing of V8VarConverter. BUG=177017 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219222

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -84 lines)			Patch
M	content/renderer/pepper/message_channel.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/resource_converter.h	View		1 chunk	+14 lines, -10 lines	0 comments	Download
M	content/renderer/pepper/resource_converter.cc	View		1 chunk	+8 lines, -6 lines	0 comments	Download
M	content/renderer/pepper/v8_var_converter.h	View		1 chunk	+39 lines, -29 lines	0 comments	Download
M	content/renderer/pepper/v8_var_converter.cc	View	1	13 chunks	+32 lines, -29 lines	0 comments	Download
M	content/renderer/pepper/v8_var_converter_unittest.cc	View	1	8 chunks	+21 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/23330008/3001

7 years, 4 months ago (2013-08-23 01:16:16 UTC) #3

Message was sent while issue was closed.

Change committed as 219222

Expand Messages | Collapse Messages