Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Issue 23330008: Introduce MockResourceConverter to modularize testing of V8VarConverter (Closed)

Created:
7 years, 4 months ago by raymes
Modified:
7 years, 4 months ago
Reviewers:
teravest
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Introduce MockResourceConverter to modularize testing of V8VarConverter This changes V8VarConverter into a class which has a constructor which is used specifically for testing. It accepts the MessageLoopProxy to run callbacks on and a ResourceConverter (which can be mocked). This allows more modular testing of V8VarConverter. BUG=177017 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219222

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -84 lines) Patch
M content/renderer/pepper/message_channel.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/resource_converter.h View 1 chunk +14 lines, -10 lines 0 comments Download
M content/renderer/pepper/resource_converter.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M content/renderer/pepper/v8_var_converter.h View 1 chunk +39 lines, -29 lines 0 comments Download
M content/renderer/pepper/v8_var_converter.cc View 1 13 chunks +32 lines, -29 lines 0 comments Download
M content/renderer/pepper/v8_var_converter_unittest.cc View 1 8 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
raymes
7 years, 4 months ago (2013-08-22 06:43:15 UTC) #1
teravest
lgtm
7 years, 4 months ago (2013-08-22 14:24:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/23330008/3001
7 years, 4 months ago (2013-08-23 01:16:16 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 05:26:41 UTC) #4
Message was sent while issue was closed.
Change committed as 219222

Powered by Google App Engine
This is Rietveld 408576698