Introduce MockResourceConverter to modularize testing of V8VarConverter

content/renderer/pepper/message_channel.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/message_channel.h"
 
 #include <cstdlib>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 336 matching lines @@
           ppapi::ScopedPPVar(ppapi::ScopedPPVar::PassRef(),
                              StringVar::StringToPPVar(
                                  NPVARIANT_TO_STRING(*variant).UTF8Characters,
                                  NPVARIANT_TO_STRING(*variant).UTF8Length)),
           true);
       return;
     case NPVariantType_Object: {
       // Calling WebBindings::toV8Value creates a wrapper around NPVariant so it
       // shouldn't result in a deep copy.
       v8::Handle<v8::Value> v8_value = WebBindings::toV8Value(variant);
-      V8VarConverter::FromV8Value(v8_value, v8::Context::GetCurrent(),
+      V8VarConverter().FromV8Value(v8_value, v8::Context::GetCurrent(),
           base::Bind(&MessageChannel::NPVariantToPPVarComplete,
               weak_ptr_factory_.GetWeakPtr(), result_iterator));
       return;
     }
   }
   NPVariantToPPVarComplete(result_iterator,
       ppapi::ScopedPPVar(PP_MakeUndefined()), false);
 }
 
 void MessageChannel::PostMessageToJavaScript(PP_Var message_data) {
   v8::HandleScope scope;
 
   // Because V8 is probably not on the stack for Native->JS calls, we need to
   // enter the appropriate context for the plugin.
   WebPluginContainer* container = instance_->container();
   // It's possible that container() is NULL if the plugin has been removed from
   // the DOM (but the PluginInstance is not destroyed yet).
   if (!container)
     return;
 
   v8::Local<v8::Context> context =
       container->element().document().frame()->mainWorldScriptContext();
   // If the page is being destroyed, the context may be empty.
   if (context.IsEmpty())
     return;
   v8::Context::Scope context_scope(context);
 
   v8::Handle<v8::Value> v8_val;
-  if (!V8VarConverter::ToV8Value(message_data, context, &v8_val)) {
+  if (!V8VarConverter().ToV8Value(message_data, context, &v8_val)) {
     PpapiGlobals::Get()->LogWithSource(instance_->pp_instance(),
         PP_LOGLEVEL_ERROR, std::string(), kVarToV8ConversionError);
     return;
   }
 
   // This is for backward compatibility. It usually makes sense for us to return
   // a string object rather than a string primitive because it allows multiple
   // references to the same string (as with PP_Var strings). However, prior to
   // implementing dictionary and array, vars we would return a string primitive
   // here. Changing it to an object now will break existing code that uses
@@ skipping 152 matching lines @@
   // incoming passthrough object first, so that we behave correctly if anyone
   // invokes:
   //   SetPassthroughObject(passthrough_object());
   if (passthrough_object_)
     WebBindings::releaseObject(passthrough_object_);
 
   passthrough_object_ = passthrough;
 }
 
 }  // namespace content