Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: content/renderer/pepper/resource_converter.h

Issue 23330008: Introduce MockResourceConverter to modularize testing of V8VarConverter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/message_channel.cc ('k') | content/renderer/pepper/resource_converter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/resource_converter.h
diff --git a/content/renderer/pepper/resource_converter.h b/content/renderer/pepper/resource_converter.h
index bebd7a3f3c5f1c07d33069c61201c79349c0e213..33287c935c6bf3d6cc5358d6149df651bbcbe71d 100644
--- a/content/renderer/pepper/resource_converter.h
+++ b/content/renderer/pepper/resource_converter.h
@@ -8,24 +8,28 @@
#include "base/basictypes.h"
#include "base/callback.h"
#include "base/compiler_specific.h"
-#include "base/message_loop/message_loop_proxy.h"
+#include "content/common/content_export.h"
namespace content {
// This class is responsible for converting V8 vars to Pepper resources.
-class ResourceConverter {
+class CONTENT_EXPORT ResourceConverter {
public:
- ResourceConverter();
- ~ResourceConverter();
- // ShutDown must be called before any vars created by the ResourceConverter
+ virtual ~ResourceConverter();
+
+ // ShutDown must be called before any vars created by the ResourceConverter
// are valid. It handles creating any resource hosts that need to be created.
- // |message_loop_proxy| is the message loop to run the callback from.
- void ShutDown(
- const base::Callback<void(bool)>& callback,
- const scoped_refptr<base::MessageLoopProxy>& message_loop_proxy);
+ virtual void ShutDown(const base::Callback<void(bool)>& callback) = 0;
+};
+
+class ResourceConverterImpl : public ResourceConverter {
+ public:
+ ResourceConverterImpl();
+ virtual ~ResourceConverterImpl();
+ virtual void ShutDown(const base::Callback<void(bool)>& callback) OVERRIDE;
private:
- DISALLOW_COPY_AND_ASSIGN(ResourceConverter);
+ DISALLOW_COPY_AND_ASSIGN(ResourceConverterImpl);
};
} // namespace content
« no previous file with comments | « content/renderer/pepper/message_channel.cc ('k') | content/renderer/pepper/resource_converter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698