Set up content in-process main threads via factory

Set up content in-process main threads via factory

This code was previously #ifdef'd out based on CHROME_MULTIPLE_DLL. This works
for chrome, but not for test targets which link content_browser. content_browser
needs to not link against child-only targets (as they'll cause linking blink
into the browser dll).

Instead of having utility_process_host_impl, et al. own the in-process
implementation, use a factory to create them that's installed in test code, and
in chrome for supporting --single-process.

At the same time, remove the global CHROME_MULTIPLE_DLL define and localize it
to chrome_exe.gypi because it's too easy to use incorrectly.

TBR=darin
R=piman@chromium.org,jam@chromium.org
BUG=237249
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217968

[scottmg, 2013-08-15 21:45:03]

piman, could you take a look?

(adding jam as fyi, as he reviewed a bunch of other related changes, but is
unavailable for a few weeks)

[piman, 2013-08-15 22:26:10]

lgtm

https://codereview.chromium.org/23235002/diff/20001/content/browser/utility_p...
File content/browser/utility_process_host_impl.h (right):

https://codereview.chromium.org/23235002/diff/20001/content/browser/utility_p...
content/browser/utility_process_host_impl.h:16: #include
"base/threading/thread.h"
nit: forward declare instead?

[scottmg, 2013-08-15 22:40:37]

thanks

https://codereview.chromium.org/23235002/diff/20001/content/browser/utility_p...
File content/browser/utility_process_host_impl.h (right):

https://codereview.chromium.org/23235002/diff/20001/content/browser/utility_p...
content/browser/utility_process_host_impl.h:16: #include
"base/threading/thread.h"
On 2013/08/15 22:26:11, piman wrote:
> nit: forward declare instead?

Done.

[commit-bot: I haz the power, 2013-08-16 03:28:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/23235002/47001

[commit-bot: I haz the power, 2013-08-16 03:43:44]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[scottmg, 2013-08-16 03:44:59]

tbr darin for chrome/app/chrome_main_delegate.cc define rename

[commit-bot: I haz the power, 2013-08-16 03:45:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/23235002/47001

[commit-bot: I haz the power, 2013-08-16 07:45:45]

Change committed as 217968

[jam, 2013-08-25 08:09:16]

some nits: 

also:
1) in content.gyp, content_browser shouldn't depend on gpu/utility/renderer
anymore

2) the new files that you're moving need to be renamed to signify that they're
only used for in-process case. otherwise they look like they're being used in
their respective processes.  so in_process_gpu_thread,
in_process_renderer_thread, in_process_utility_thread (you can drop the "main"
in all of these), and of course also rename the classes to match the filenames

https://chromiumcodereview.appspot.com/23235002/diff/47001/content/browser/gp...
File content/browser/gpu/gpu_process_host.cc (right):

https://chromiumcodereview.appspot.com/23235002/diff/47001/content/browser/gp...
content/browser/gpu/gpu_process_host.cc:28: #include "content/gpu/gpu_process.h"
nit: remove these and and "content/gpu" from content/browser/DEPS (the comment
there is out of date, these two files are the only ones that cause that bad
dependency to be there)