Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 22882007: Remove GetActiveEntry usage from chrome/browser/ui.

Created:
7 years, 4 months ago by nasko
Modified:
7 years, 2 months ago
Reviewers:
CC:
chromium-reviews, skanuj+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, ahutter, mad+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, tim+watch_chromium.org, melevin+watch_chromium.org, benquan, dominich, rouslan+autofillwatch_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, dyu1, haitaol+watch_chromium.org, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, Raman Kakilate, Jered, tfarina, donnd+watch_chromium.org, David Black, Dane Wallinga, samarth+watch_chromium.org, estade+watch_chromium.org, rsimha+watch_chromium.org
Visibility:
Public.

Description

Remove GetActiveEntry usage from chrome/browser/ui. Using GetActiveEntry can lead to subtle bugs, including security ones. See the bug entry for more details. BUG=273710

Patch Set 1 #

Patch Set 2 : Fixing compile breaks. #

Patch Set 3 : Rebased on ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -39 lines) Patch
M chrome/browser/sync/glue/session_change_processor.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_model_associator_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate_android.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate_android.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_loader.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_page_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_codec.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/android/navigation_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_page_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698