chrome/browser/ui/tabs/pinned_tab_codec.cc - Issue 22882007: Remove GetActiveEntry usage from chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/pinned_tab_codec.cc

Issue 22882007: Remove GetActiveEntry usage from chrome/browser/ui. Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased on ToT. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tabs/pinned_tab_codec.cc

diff --git a/chrome/browser/ui/tabs/pinned_tab_codec.cc b/chrome/browser/ui/tabs/pinned_tab_codec.cc

index 66985b62e331e9ba9a99061989ee6fdf567246ee..9c8c8c4df4652a233313c456513b767f4ab09b28 100644

--- a/chrome/browser/ui/tabs/pinned_tab_codec.cc

+++ b/chrome/browser/ui/tabs/pinned_tab_codec.cc

@@ -67,7 +67,7 @@ static void EncodePinnedTab(TabStripModel* model,

kURL, extensions::AppLaunchInfo::GetFullLaunchURL(extension).spec());

values->Append(value.release());

} else {

- NavigationEntry* entry = web_contents->GetController().GetActiveEntry();

+ NavigationEntry* entry = web_contents->GetController().GetVisibleEntry();

if (!entry && web_contents->GetController().GetEntryCount())

entry = web_contents->GetController().GetEntryAtIndex(0);

if (entry) {