chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc - Issue 22882007: Remove GetActiveEntry usage from chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

Issue 22882007: Remove GetActiveEntry usage from chrome/browser/ui. Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased on ToT. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/synced_tab_delegate_android.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

diff --git a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

index 7346b2466eee2ff51de1e3597e370f416b9041ad..7778fa7247c1ed21f77cef439402888417fda21b 100644

--- a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

+++ b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

@@ -195,8 +195,7 @@ void AutofillDialogControllerAndroid::Show() {

JNIEnv* env = base::android::AttachCurrentThread();

dialog_shown_timestamp_ = base::Time::Now();

- content::NavigationEntry* entry = contents_->GetController().GetActiveEntry();

- const GURL& active_url = entry ? entry->GetURL() : contents_->GetURL();

+ const GURL& active_url = contents_->GetLastCommittedURL();

invoked_from_same_origin_ = active_url.GetOrigin() == source_url_.GetOrigin();

// Determine what field types should be included in the dialog.