chrome/browser/ui/webui/inspect_ui.cc - Issue 22882007: Remove GetActiveEntry usage from chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 22882007: Remove GetActiveEntry usage from chrome/browser/ui. Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased on ToT. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/inspect_ui.cc

diff --git a/chrome/browser/ui/webui/inspect_ui.cc b/chrome/browser/ui/webui/inspect_ui.cc

index 5f52409f5ed367698e63e3637a6135e774a75ec2..f6cfefbcf5c894fdc1d519a15c0e9600de9fdf4e 100644

--- a/chrome/browser/ui/webui/inspect_ui.cc

+++ b/chrome/browser/ui/webui/inspect_ui.cc

@@ -163,7 +163,7 @@ DictionaryValue* BuildTargetDescriptor(RenderViewHost* rvh, bool is_tab) {

url = web_contents->GetURL();

title = UTF16ToUTF8(web_contents->GetTitle());

content::NavigationController& controller = web_contents->GetController();

- content::NavigationEntry* entry = controller.GetActiveEntry();

+ content::NavigationEntry* entry = controller.GetVisibleEntry();

if (entry != NULL && entry->GetURL().is_valid())

favicon_url = entry->GetFavicon().url;