Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 22880029: Make AttachBehavior a required argument. (Closed)

Created:
7 years, 4 months ago by ojan
Modified:
7 years, 4 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, nessy, eae+blinkwatch, feature-media-reviews_chromium.org, dglazkov+blink, f(malita), adamk+blink_chromium.org, pdr, Stephen Chennney, vcarbune.chromium
Visibility:
Public.

Description

Make AttachBehavior a required argument. This way we have a clear list of DeprecatedAttachNow calls to work through. This required making ExceptionState a required argument as well. In a future patch, I'll make AttachBehavior default to AttachLazily and ExceptionState default to ASSERT_NO_EXCEPTION. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -111 lines) Patch
M Source/core/dom/ContainerNode.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Range.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MergeIdenticalElementsCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/RemoveNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ReplaceNodeWithSpanCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/SplitElementCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/SplitTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/BaseButtonInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/ColorInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/FileInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTitleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RangeInputType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/SearchInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/TextFieldInputType.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/PasswordGeneratorButtonElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ojan
7 years, 4 months ago (2013-08-21 20:00:40 UTC) #1
esprehn
LGTM, lots of these can actually be AttachLazily, I had just skipped over ones on ...
7 years, 4 months ago (2013-08-21 20:11:35 UTC) #2
ojan
On 2013/08/21 20:11:35, esprehn wrote: > LGTM, lots of these can actually be AttachLazily, I ...
7 years, 4 months ago (2013-08-21 20:24:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/22880029/1
7 years, 4 months ago (2013-08-21 20:24:25 UTC) #4
eseidel
Fantastic!
7 years, 4 months ago (2013-08-21 20:56:02 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 23:02:42 UTC) #6
Message was sent while issue was closed.
Change committed as 156514

Powered by Google App Engine
This is Rietveld 408576698