Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: Source/core/svg/SVGUseElement.cpp

Issue 22880029: Make AttachBehavior a required argument. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/DragController.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGUseElement.cpp
diff --git a/Source/core/svg/SVGUseElement.cpp b/Source/core/svg/SVGUseElement.cpp
index 06b3c7a956ed6d6a9e6aadbab07e7a54bbc5a334..b77d1ba07a69512de30724fe04eca98d854abeb9 100644
--- a/Source/core/svg/SVGUseElement.cpp
+++ b/Source/core/svg/SVGUseElement.cpp
@@ -691,7 +691,7 @@ void SVGUseElement::buildShadowTree(SVGElement* target, SVGElementInstance* targ
if (subtreeContainsDisallowedElement(newChild.get()))
removeDisallowedElementsFromSubtree(newChild.get());
- userAgentShadowRoot()->appendChild(newChild.release());
+ userAgentShadowRoot()->appendChild(newChild.release(), ASSERT_NO_EXCEPTION, DeprecatedAttachNow);
}
void SVGUseElement::expandUseElementsInShadowTree(Node* element)
@@ -724,7 +724,7 @@ void SVGUseElement::expandUseElementsInShadowTree(Node* element)
if (target && !isDisallowedElement(target)) {
RefPtr<Element> newChild = target->cloneElementWithChildren();
ASSERT(newChild->isSVGElement());
- cloneParent->appendChild(newChild.release());
+ cloneParent->appendChild(newChild.release(), ASSERT_NO_EXCEPTION, DeprecatedAttachNow);
}
// We don't walk the target tree element-by-element, and clone each element,
@@ -739,7 +739,7 @@ void SVGUseElement::expandUseElementsInShadowTree(Node* element)
// Replace <use> with referenced content.
ASSERT(use->parentNode());
- use->parentNode()->replaceChild(cloneParent.release(), use);
+ use->parentNode()->replaceChild(cloneParent.release(), use, ASSERT_NO_EXCEPTION, DeprecatedAttachNow);
// Expand the siblings because the *element* is replaced and we will
// lose the sibling chain when we are back from recursion.
@@ -769,7 +769,7 @@ void SVGUseElement::expandSymbolElementsInShadowTree(Node* element)
// Only clone symbol children, and add them to the new <svg> element
for (Node* child = element->firstChild(); child; child = child->nextSibling()) {
RefPtr<Node> newChild = child->cloneNode(true);
- svgElement->appendChild(newChild.release());
+ svgElement->appendChild(newChild.release(), ASSERT_NO_EXCEPTION, DeprecatedAttachNow);
}
// We don't walk the target tree element-by-element, and clone each element,
@@ -783,7 +783,7 @@ void SVGUseElement::expandSymbolElementsInShadowTree(Node* element)
RefPtr<Node> replacingElement(svgElement.get());
// Replace <symbol> with <svg>.
- element->parentNode()->replaceChild(svgElement.release(), element);
+ element->parentNode()->replaceChild(svgElement.release(), element, ASSERT_NO_EXCEPTION, DeprecatedAttachNow);
// Expand the siblings because the *element* is replaced and we will
// lose the sibling chain when we are back from recursion.
« no previous file with comments | « Source/core/page/DragController.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698