Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: Source/core/html/TextFieldInputType.cpp

Issue 22880029: Make AttachBehavior a required argument. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/SearchInputType.cpp ('k') | Source/core/html/shadow/DateTimeEditElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/TextFieldInputType.cpp
diff --git a/Source/core/html/TextFieldInputType.cpp b/Source/core/html/TextFieldInputType.cpp
index ec2a8b2708b75ebc210bbd037792dc91ee4d61ac..6cf72379764d94f0ec3d4d041f7bbf25f3f7b97f 100644
--- a/Source/core/html/TextFieldInputType.cpp
+++ b/Source/core/html/TextFieldInputType.cpp
@@ -251,26 +251,26 @@ void TextFieldInputType::createShadowSubtree()
m_innerText = TextControlInnerTextElement::create(document);
if (!createsContainer) {
- element()->userAgentShadowRoot()->appendChild(m_innerText, IGNORE_EXCEPTION);
+ element()->userAgentShadowRoot()->appendChild(m_innerText, IGNORE_EXCEPTION, DeprecatedAttachNow);
return;
}
ShadowRoot* shadowRoot = element()->userAgentShadowRoot();
m_container = TextControlInnerContainer::create(document);
m_container->setPart(AtomicString("-webkit-textfield-decoration-container", AtomicString::ConstructFromLiteral));
- shadowRoot->appendChild(m_container, IGNORE_EXCEPTION);
+ shadowRoot->appendChild(m_container, IGNORE_EXCEPTION, DeprecatedAttachNow);
m_innerBlock = TextControlInnerElement::create(document);
- m_innerBlock->appendChild(m_innerText, IGNORE_EXCEPTION);
- m_container->appendChild(m_innerBlock, IGNORE_EXCEPTION);
+ m_innerBlock->appendChild(m_innerText, IGNORE_EXCEPTION, DeprecatedAttachNow);
+ m_container->appendChild(m_innerBlock, IGNORE_EXCEPTION, DeprecatedAttachNow);
#if ENABLE(INPUT_SPEECH)
if (element()->isSpeechEnabled())
- m_container->appendChild(InputFieldSpeechButtonElement::create(document), IGNORE_EXCEPTION);
+ m_container->appendChild(InputFieldSpeechButtonElement::create(document), IGNORE_EXCEPTION, DeprecatedAttachNow);
#endif
if (shouldHaveSpinButton)
- m_container->appendChild(SpinButtonElement::create(document, *this), IGNORE_EXCEPTION);
+ m_container->appendChild(SpinButtonElement::create(document, *this), IGNORE_EXCEPTION, DeprecatedAttachNow);
}
HTMLElement* TextFieldInputType::containerElement() const
@@ -416,7 +416,7 @@ void TextFieldInputType::updatePlaceholderText()
if (!m_placeholder) {
m_placeholder = HTMLDivElement::create(element()->document());
m_placeholder->setPart(AtomicString("-webkit-input-placeholder", AtomicString::ConstructFromLiteral));
- element()->userAgentShadowRoot()->insertBefore(m_placeholder, m_container ? m_container->nextSibling() : innerTextElement()->nextSibling(), ASSERT_NO_EXCEPTION);
+ element()->userAgentShadowRoot()->insertBefore(m_placeholder, m_container ? m_container->nextSibling() : innerTextElement()->nextSibling(), ASSERT_NO_EXCEPTION, DeprecatedAttachNow);
}
m_placeholder->setInnerText(placeholderText, ASSERT_NO_EXCEPTION);
element()->fixPlaceholderRenderer(m_placeholder.get(), m_container ? m_container.get() : m_innerText.get());
« no previous file with comments | « Source/core/html/SearchInputType.cpp ('k') | Source/core/html/shadow/DateTimeEditElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698