Move ownership of audio/video sinks to MojoRendererService.

Move ownership of audio/video sinks to MojoRendererService.

Otherwise they get shared between multiple instances of Renderer
and do not get destroyed when media pipeline is destroyed.

BUG=641559
Committed: https://crrev.com/0b72920835dc60afae7c1f159ebc75008969de0f
Cr-Commit-Position: refs/heads/master@{#415502}

[alokp, 2016-08-27 00:31:53]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 00:32:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alokp, 2016-08-27 00:33:33]

alokp@chromium.org changed reviewers:
+ xhwang@chromium.org

[alokp, 2016-08-27 00:33:34]

Please see if the approach is OK. I will update all implementations of
MojoMediaClient if this looks reasonable.

With this patch all *MediaSessionVisibilityBrowserTest* pass.

[commit-bot: I haz the power, 2016-08-27 00:54:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 00:54:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alokp, 2016-08-27 03:59:21]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 03:59:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 05:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 05:08:25]

Dry run: This issue passed the CQ dry run.

[alokp, 2016-08-29 20:34:42]

alokp@chromium.org changed reviewers:
+ jrummell@chromium.org

[alokp, 2016-08-29 20:34:42]

+jrummel since xhwang@ is OOO and who originally moved the ownership to
MojoMediaClient

[jrummell, 2016-08-30 19:59:59]

media/ lgtm

https://codereview.chromium.org/2281843003/diff/40001/chromecast/browser/medi...
File chromecast/browser/media/cast_mojo_media_client.cc (right):

https://codereview.chromium.org/2281843003/diff/40001/chromecast/browser/medi...
chromecast/browser/media/cast_mojo_media_client.cc:55: return nullptr;
Do you need this? It looks the same as the base class (and you don't override
CreateVideoRendererSink).

[alokp, 2016-08-30 20:08:52]

https://codereview.chromium.org/2281843003/diff/40001/chromecast/browser/medi...
File chromecast/browser/media/cast_mojo_media_client.cc (right):

https://codereview.chromium.org/2281843003/diff/40001/chromecast/browser/medi...
chromecast/browser/media/cast_mojo_media_client.cc:55: return nullptr;
On 2016/08/30 19:59:59, jrummell wrote:
> Do you need this? It looks the same as the base class (and you don't override
> CreateVideoRendererSink).

I plan to. I need to capture the audio_device_id here. I first wanted to check
with you if the basic idea is acceptable with media team. Thanks for reviewing.

[alokp, 2016-08-30 20:31:57]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2016-08-30 20:33:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 20:36:33]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alokp, 2016-08-30 22:28:09]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-08-30 22:28:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org
Link to the patchset: https://codereview.chromium.org/2281843003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-30 22:28:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 00:00:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-31 00:02:57]

Description was changed from

==========
Move ownership of audio/video sinks to MojoRendererService.

Otherwise they get shared between multiple instances of Renderer
and do not get destroyed when media pipeline is destroyed.

BUG=641559
==========

to

==========
Move ownership of audio/video sinks to MojoRendererService.

Otherwise they get shared between multiple instances of Renderer
and do not get destroyed when media pipeline is destroyed.

BUG=641559

Committed: https://crrev.com/0b72920835dc60afae7c1f159ebc75008969de0f
Cr-Commit-Position: refs/heads/master@{#415502}
==========

[commit-bot: I haz the power, 2016-08-31 00:03:00]

Patchset 4 (id:??) landed as
https://crrev.com/0b72920835dc60afae7c1f159ebc75008969de0f
Cr-Commit-Position: refs/heads/master@{#415502}