Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: media/mojo/services/mojo_renderer_service.cc

Issue 2281843003: Move ownership of audio/video sinks to MojoRendererService. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/mojo_renderer_service.h ('k') | media/mojo/services/service_factory_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_renderer_service.cc
diff --git a/media/mojo/services/mojo_renderer_service.cc b/media/mojo/services/mojo_renderer_service.cc
index 96ca86ed93a6e1e4c70f87a8563f4508da88eaae..40c7006c1f10d6dfa8373197958cd537d86c6ec2 100644
--- a/media/mojo/services/mojo_renderer_service.cc
+++ b/media/mojo/services/mojo_renderer_service.cc
@@ -7,9 +7,11 @@
#include <utility>
#include "base/bind.h"
+#include "media/base/audio_renderer_sink.h"
#include "media/base/media_keys.h"
#include "media/base/media_url_demuxer.h"
#include "media/base/renderer.h"
+#include "media/base/video_renderer_sink.h"
#include "media/mojo/services/demuxer_stream_provider_shim.h"
#include "media/mojo/services/mojo_cdm_service_context.h"
@@ -20,11 +22,15 @@ const int kTimeUpdateIntervalMs = 50;
MojoRendererService::MojoRendererService(
base::WeakPtr<MojoCdmServiceContext> mojo_cdm_service_context,
+ scoped_refptr<AudioRendererSink> audio_sink,
+ std::unique_ptr<VideoRendererSink> video_sink,
std::unique_ptr<media::Renderer> renderer,
mojo::InterfaceRequest<mojom::Renderer> request)
: binding_(this, std::move(request)),
mojo_cdm_service_context_(mojo_cdm_service_context),
state_(STATE_UNINITIALIZED),
+ audio_sink_(std::move(audio_sink)),
+ video_sink_(std::move(video_sink)),
renderer_(std::move(renderer)),
weak_factory_(this) {
DVLOG(1) << __FUNCTION__;
« no previous file with comments | « media/mojo/services/mojo_renderer_service.h ('k') | media/mojo/services/service_factory_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698