Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: media/mojo/services/test_mojo_media_client.h

Issue 2281843003: Move ownership of audio/video sinks to MojoRendererService. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/service_factory_impl.cc ('k') | media/mojo/services/test_mojo_media_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/test_mojo_media_client.h
diff --git a/media/mojo/services/test_mojo_media_client.h b/media/mojo/services/test_mojo_media_client.h
index f6e0aa2219492ef38788129b102e4efe01fcaecc..78c63dc2e6f1bb89e73b22c8fd3d4a9a2d24a88e 100644
--- a/media/mojo/services/test_mojo_media_client.h
+++ b/media/mojo/services/test_mojo_media_client.h
@@ -32,23 +32,17 @@ class TestMojoMediaClient : public MojoMediaClient {
// MojoMediaClient implementation.
void Initialize() final;
void WillQuit() final;
- std::unique_ptr<Renderer> CreateRenderer(
- scoped_refptr<base::SingleThreadTaskRunner> media_task_runner,
- scoped_refptr<MediaLog> media_log,
+ scoped_refptr<AudioRendererSink> CreateAudioRendererSink(
const std::string& audio_device_id) final;
+ std::unique_ptr<VideoRendererSink> CreateVideoRendererSink(
+ const scoped_refptr<base::SingleThreadTaskRunner>& task_runner) final;
+ std::unique_ptr<RendererFactory> CreateRendererFactory(
+ const scoped_refptr<MediaLog>& media_log) final;
std::unique_ptr<CdmFactory> CreateCdmFactory(
shell::mojom::InterfaceProvider* /* interface_provider */) final;
private:
- RendererFactory* GetRendererFactory(scoped_refptr<MediaLog> media_log);
- AudioRendererSink* GetAudioRendererSink();
- VideoRendererSink* GetVideoRendererSink(
- const scoped_refptr<base::SingleThreadTaskRunner>& task_runner);
-
ScopedAudioManagerPtr audio_manager_;
- std::unique_ptr<RendererFactory> renderer_factory_;
- scoped_refptr<AudioRendererSink> audio_renderer_sink_;
- std::unique_ptr<VideoRendererSink> video_renderer_sink_;
DISALLOW_COPY_AND_ASSIGN(TestMojoMediaClient);
};
« no previous file with comments | « media/mojo/services/service_factory_impl.cc ('k') | media/mojo/services/test_mojo_media_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698