Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: net/base/network_delegate_impl.cc

Issue 2262653003: Make URLRequest::Read to return net errors or bytes read instead of a bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/network_delegate_impl.cc
diff --git a/net/base/network_delegate_impl.cc b/net/base/network_delegate_impl.cc
index fa573e9e80f079075fa5eaad4e306ba0378b07e0..be48c3ff0224e6b5bb3f278e377488401c906515 100644
--- a/net/base/network_delegate_impl.cc
+++ b/net/base/network_delegate_impl.cc
@@ -41,21 +41,31 @@ int NetworkDelegateImpl::OnHeadersReceived(
}
void NetworkDelegateImpl::OnBeforeRedirect(URLRequest* request,
- const GURL& new_location) {
-}
+ const GURL& new_location) {}
-void NetworkDelegateImpl::OnResponseStarted(URLRequest* request) {
+void NetworkDelegateImpl::OnResponseStarted(URLRequest* request,
+ int net_error) {
+ OnResponseStarted(request);
}
+// Deprecated.
+void NetworkDelegateImpl::OnResponseStarted(URLRequest* request) {}
+
void NetworkDelegateImpl::OnNetworkBytesReceived(URLRequest* request,
int64_t bytes_received) {}
void NetworkDelegateImpl::OnNetworkBytesSent(URLRequest* request,
int64_t bytes_sent) {}
-void NetworkDelegateImpl::OnCompleted(URLRequest* request, bool started) {
+void NetworkDelegateImpl::OnCompleted(URLRequest* request,
+ bool started,
+ int net_error) {
+ OnCompleted(request, started);
}
+// Deprecated.
+void NetworkDelegateImpl::OnCompleted(URLRequest* request, bool started) {}
+
void NetworkDelegateImpl::OnURLRequestDestroyed(URLRequest* request) {
}

Powered by Google App Engine
This is Rietveld 408576698