Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2680)

Unified Diff: net/base/network_delegate_impl.h

Issue 2262653003: Make URLRequest::Read to return net errors or bytes read instead of a bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/network_delegate_impl.h
diff --git a/net/base/network_delegate_impl.h b/net/base/network_delegate_impl.h
index b2d56c770d5d802960ee2bf520162acd32115951..b62f22579f5a98ac83bd9a790c1c3fe9097973f4 100644
--- a/net/base/network_delegate_impl.h
+++ b/net/base/network_delegate_impl.h
@@ -104,6 +104,9 @@ class NET_EXPORT NetworkDelegateImpl : public NetworkDelegate {
void OnBeforeRedirect(URLRequest* request, const GURL& new_location) override;
// This corresponds to URLRequestDelegate::OnResponseStarted.
+ void OnResponseStarted(URLRequest* request, int net_error) override;
+ // Deprecated.
+ // TODO(maksims): Remove this;
void OnResponseStarted(URLRequest* request) override;
// Called when bytes are received from the network, such as after receiving
@@ -129,6 +132,9 @@ class NET_EXPORT NetworkDelegateImpl : public NetworkDelegate {
// Indicates that the URL request has been completed or failed.
// |started| indicates whether the request has been started. If false,
// some information like the socket address is not available.
+ void OnCompleted(URLRequest* request, bool started, int net_error) override;
+ // Deprecated.
+ // TODO(maksims): Remove this;
void OnCompleted(URLRequest* request, bool started) override;
// Called when an URLRequest is being destroyed. Note that the request is

Powered by Google App Engine
This is Rietveld 408576698