Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1819)

Unified Diff: net/test/embedded_test_server/embedded_test_server_unittest.cc

Issue 2262653003: Make URLRequest::Read to return net errors or bytes read instead of a bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/test/embedded_test_server/embedded_test_server_unittest.cc
diff --git a/net/test/embedded_test_server/embedded_test_server_unittest.cc b/net/test/embedded_test_server/embedded_test_server_unittest.cc
index a143ae376bc8fde029acecf485a0a0881006ee17..3919b98bd5d2790d6a8036cdb93c6a667be66611 100644
--- a/net/test/embedded_test_server/embedded_test_server_unittest.cc
+++ b/net/test/embedded_test_server/embedded_test_server_unittest.cc
@@ -389,8 +389,8 @@ class CancelRequestDelegate : public TestDelegate {
CancelRequestDelegate() {}
~CancelRequestDelegate() override {}
- void OnResponseStarted(URLRequest* request) override {
- TestDelegate::OnResponseStarted(request);
+ void OnResponseStarted(URLRequest* request, int net_error) override {
+ TestDelegate::OnResponseStarted(request, net_error);
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
FROM_HERE, run_loop_.QuitClosure(), base::TimeDelta::FromSeconds(1));
}

Powered by Google App Engine
This is Rietveld 408576698