Make URLRequest::Read to return net errors or bytes read instead of a bool

net/base/layered_network_delegate.h

Index: net/base/layered_network_delegate.h
diff --git a/net/base/layered_network_delegate.h b/net/base/layered_network_delegate.h
index ba7ecc710f9805e3b35fa52f616aa1f2b265e44b..6c8a502e6ab059ed06f67bce3a30523252321829 100644
--- a/net/base/layered_network_delegate.h
+++ b/net/base/layered_network_delegate.h
@@ -59,11 +59,12 @@ class NET_EXPORT LayeredNetworkDelegate : public NetworkDelegate {
       scoped_refptr<HttpResponseHeaders>* override_response_headers,
       GURL* allowed_unsafe_redirect_url) final;
   void OnBeforeRedirect(URLRequest* request, const GURL& new_location) final;
-  void OnResponseStarted(URLRequest* request) final;
+
+  void OnResponseStarted(URLRequest* request, int net_error) final;

[battre, 2016/09/29 13:07:29]

Shouldn't this be "net::Error net_error" (also in all other cases)?

   void OnNetworkBytesReceived(URLRequest* request,
                               int64_t bytes_received) final;
   void OnNetworkBytesSent(URLRequest* request, int64_t bytes_sent) final;
-  void OnCompleted(URLRequest* request, bool started) final;
+  void OnCompleted(URLRequest* request, bool started, int net_error) final;
   void OnURLRequestDestroyed(URLRequest* request) final;
   void OnPACScriptError(int line_number, const base::string16& error) final;
   AuthRequiredResponse OnAuthRequired(URLRequest* request,