Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 21948002: Add missing DCHECK to validate HR. (Closed)

Created:
7 years, 4 months ago by etienneb
Modified:
7 years, 4 months ago
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add missing DCHECK to validate HR. This issue was found by a linter. The value of 'hr' is ignored. Probably a nice idea to validate the CreateInstance success. R=amit@chromium.org,tommi@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218662

Patch Set 1 : fix missing check to hr #

Total comments: 6

Patch Set 2 : fix error testing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome_frame/urlmon_bind_status_callback.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome_frame/urlmon_moniker.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
etienneb
PTAL.
7 years, 4 months ago (2013-08-02 18:29:07 UTC) #1
robertshield
https://chromiumcodereview.appspot.com/21948002/diff/3001/chrome_frame/urlmon_bind_status_callback.cc File chrome_frame/urlmon_bind_status_callback.cc (right): https://chromiumcodereview.appspot.com/21948002/diff/3001/chrome_frame/urlmon_bind_status_callback.cc#newcode323 chrome_frame/urlmon_bind_status_callback.cc:323: if (hr != S_OK) FAILED(hr)
7 years, 4 months ago (2013-08-02 18:35:42 UTC) #2
tommi (sloooow) - chröme
https://chromiumcodereview.appspot.com/21948002/diff/3001/chrome_frame/urlmon_bind_status_callback.cc File chrome_frame/urlmon_bind_status_callback.cc (right): https://chromiumcodereview.appspot.com/21948002/diff/3001/chrome_frame/urlmon_bind_status_callback.cc#newcode323 chrome_frame/urlmon_bind_status_callback.cc:323: if (hr != S_OK) On 2013/08/02 18:35:42, robertshield wrote: ...
7 years, 4 months ago (2013-08-04 12:43:12 UTC) #3
etienneb
so, what do you think? https://codereview.chromium.org/21948002/diff/3001/chrome_frame/urlmon_bind_status_callback.cc File chrome_frame/urlmon_bind_status_callback.cc (right): https://codereview.chromium.org/21948002/diff/3001/chrome_frame/urlmon_bind_status_callback.cc#newcode323 chrome_frame/urlmon_bind_status_callback.cc:323: if (hr != S_OK) ...
7 years, 4 months ago (2013-08-05 13:56:26 UTC) #4
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/21948002/diff/3001/chrome_frame/urlmon_moniker.cc File chrome_frame/urlmon_moniker.cc (right): https://codereview.chromium.org/21948002/diff/3001/chrome_frame/urlmon_moniker.cc#newcode246 chrome_frame/urlmon_moniker.cc:246: DCHECK(SUCCEEDED(hr)); On 2013/08/05 13:56:26, etienneb wrote: > I ...
7 years, 4 months ago (2013-08-05 15:10:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/21948002/17001
7 years, 4 months ago (2013-08-20 05:34:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/21948002/17001
7 years, 4 months ago (2013-08-21 03:17:51 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 06:47:37 UTC) #8
Message was sent while issue was closed.
Change committed as 218662

Powered by Google App Engine
This is Rietveld 408576698