chrome_frame/urlmon_moniker.cc - Issue 21948002: Add missing DCHECK to validate HR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/urlmon_moniker.cc

Issue 21948002: Add missing DCHECK to validate HR. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix error testing Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_frame/urlmon_moniker.cc

diff --git a/chrome_frame/urlmon_moniker.cc b/chrome_frame/urlmon_moniker.cc

index d2d5b117ce030f08065ab26f7ff2402090b6dbe7..432dd92a2483697c7758f93e9f9bfe28b330de06 100644

--- a/chrome_frame/urlmon_moniker.cc

+++ b/chrome_frame/urlmon_moniker.cc

@@ -243,6 +243,7 @@ HRESULT MonikerPatch::BindToStorage(IMoniker_BindToStorage_Fn original,

CComObject<BSCBStorageBind>* callback = NULL;

if (ShouldWrapCallback(me, iid, bind_ctx)) {

hr = CComObject<BSCBStorageBind>::CreateInstance(&callback);

+ DCHECK(SUCCEEDED(hr));

auto_release_callback = callback;

DCHECK_EQ(callback->m_dwRef, 1);

hr = callback->Initialize(me, bind_ctx);

« no previous file with comments | « chrome_frame/urlmon_bind_status_callback.cc ('k') | no next file » | no next file with comments »