Add missing DCHECK to validate HR.

chrome_frame/urlmon_bind_status_callback.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/urlmon_bind_status_callback.h"
 
 #include <mshtml.h>
 #include <shlguid.h>
 
 #include "base/logging.h"
@@ skipping 302 matching lines @@
 
 STDMETHODIMP BSCBStorageBind::OnStopBinding(HRESULT hresult, LPCWSTR error) {
   DVLOG(1) << __FUNCTION__
            << base::StringPrintf(" tid=%i", base::PlatformThread::CurrentId());
   // Report all crashes in the exception handler if we wrap the callback.
   // Note that this avoids having the VEH report a crash if an SEH earlier in
   // the chain handles the exception.
   ExceptionBarrier barrier;
 
   HRESULT hr = MayPlayBack(BSCF_LASTDATANOTIFICATION);
+  if (hr != S_OK)

[robertshield, 2013/08/02 18:35:42]

FAILED(hr)

[tommi (sloooow) - chröme, 2013/08/04 12:43:12]

No chance of S_FALSE?

[etienneb, 2013/08/05 13:56:26]

I don't think S_FALSE can be here.
At some place, the returns value of MayPlayBack is just ignored.

  if (!is_interesting) {
    // Play back report progress so far.
    MayPlayBack(flags);
    return CallbackImpl::OnDataAvailable(flags, size, format_etc, stgmed);
  }

On 2013/08/04 12:43:12, tommi wrote:

+    return hr;
   hr = CallbackImpl::OnStopBinding(hresult, error);
   ReleaseBind();
   return hr;
 }
 
 // Play back the cached data to the delegate. Normally this would happen
 // when we have read enough data to determine the renderer. In this case
 // we first play back the data from the cache and then go into a 'pass
 // through' mode.  In some cases we may end up getting OnStopBinding
 // before we get a chance to determine. Also it's possible that the
@@ skipping 85 matching lines @@
       case BINDSTATUS_CACHEFILENAMEAVAILABLE:
       case BINDSTATUS_SERVER_MIMETYPEAVAILABLE:
         return true;
       default:
         break;
     }
   }
 
   return false;
 }