Add missing DCHECK to validate HR.

chrome_frame/urlmon_moniker.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/urlmon_moniker.h"
 
 #include <exdisp.h>
 #include <shlguid.h>
 
 #include "base/strings/string_util.h"
@@ skipping 225 matching lines @@
   DCHECK(to_left == NULL);
 
   // Report a crash if the crash is in our own module.
   ExceptionBarrierReportOnlyModule barrier;
 
   HRESULT hr = S_OK;
   scoped_refptr<BSCBStorageBind> auto_release_callback;
   CComObject<BSCBStorageBind>* callback = NULL;
   if (ShouldWrapCallback(me, iid, bind_ctx)) {
     hr = CComObject<BSCBStorageBind>::CreateInstance(&callback);
+    DCHECK(SUCCEEDED(hr));

[tommi (sloooow) - chröme, 2013/08/04 12:43:12]

I think this is equivalent to checking the return value of new(), so I don't
think this is needed.

[etienneb, 2013/08/05 13:56:26]

I that case, why assign it to 'hr'?
The linter complains that 'hr' is assigned twice.

On 2013/08/04 12:43:12, tommi wrote:

[tommi (sloooow) - chröme, 2013/08/05 15:10:54]

Keeping the DCHECK is ok with me, I just don't think it's necessary.  You can
either skip assigning to hr or add the DCHECK. Up to you.

     auto_release_callback = callback;
     DCHECK_EQ(callback->m_dwRef, 1);
     hr = callback->Initialize(me, bind_ctx);
     DCHECK(SUCCEEDED(hr));
   }
 
   hr = original(me, bind_ctx, to_left, iid, obj);
 
   // If the binding terminates before the data could be played back
   // now is the chance. Sometimes OnStopBinding happens after this returns
   // and then it's too late.
   if ((S_OK == hr) && callback)
     callback->MayPlayBack(BSCF_LASTDATANOTIFICATION);
 
   return hr;
 }