services/ui: Move some files into the client lib.

services/ui: Move some files into the client lib.

Move the following out of ui/common into the public client-lib:
. GpuService
. GpuMemoryBufferImpl
. MojoGpuMemoryBuffer
. MojoGpuMemoryBufferManager
. MojoBufferBacking
These are only used by the clients, so there's no reason to build
these into the server as well.

BUG=634377
TBR=ben@ for trivial content/ changes.

Committed: https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c
Cr-Commit-Position: refs/heads/master@{#411345}

[sadrul, 2016-07-27 03:49:56]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 03:50:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 03:51:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 03:51:57]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sadrul, 2016-07-27 05:32:41]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 05:32:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 05:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 05:37:11]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2016-07-27 20:05:49]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 20:06:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 20:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:29:31]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[sadrul, 2016-07-28 04:01:45]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 04:02:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 04:04:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 04:04:15]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[sadrul, 2016-07-28 05:30:16]

Description was changed from

==========
services/ui: Move GpuService into the client lib.

BUG=none
==========

to

==========
services/ui: Move some files into the client lib.

Move the following out of ui/common into the public client-lib:
. GpuService
. GpuMemoryBufferImpl
. MojoGpuMemoryBuffer
. MojoGpuMemoryBufferManager
. MojoBufferBacking
These are only used by the clients, so there's no reason to build
these into the server as well.


BUG=none
==========

[sadrul, 2016-07-28 05:34:46]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 05:35:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-07-28 05:36:04]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-07-28 05:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 05:39:11]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Peng, 2016-07-28 13:02:28]

penghuang@chromium.org changed reviewers:
+ penghuang@chromium.org

[Peng, 2016-07-28 13:02:29]

https://codereview.chromium.org/2184943002/diff/100001/services/ui/public/cpp...
File services/ui/public/cpp/gpu_service.h (right):

https://codereview.chromium.org/2184943002/diff/100001/services/ui/public/cpp...
services/ui/public/cpp/gpu_service.h:28: class UI_EXPORT GpuService : public
gpu::GpuChannelHostFactory {
UI_EXPORT? Seems client library will be a shared library for component build. In
that case, it is fine to move this file to client library.

https://codereview.chromium.org/2184943002/diff/100001/services/ui/public/cpp...
File services/ui/public/cpp/lib/gpu_service.cc (right):

https://codereview.chromium.org/2184943002/diff/100001/services/ui/public/cpp...
services/ui/public/cpp/lib/gpu_service.cc:29: GpuService* g_gpu_service =
nullptr;
This global variable has to be in a shared library for component build. That is
why I put it in //services/ui/common. Otherwise, it may cause crash for
component build.

[sadrul, 2016-07-28 13:32:14]

https://codereview.chromium.org/2184943002/diff/100001/services/ui/public/cpp...
File services/ui/public/cpp/lib/gpu_service.cc (right):

https://codereview.chromium.org/2184943002/diff/100001/services/ui/public/cpp...
services/ui/public/cpp/lib/gpu_service.cc:29: GpuService* g_gpu_service =
nullptr;
On 2016/07/28 13:02:29, Peng wrote:
> This global variable has to be in a shared library for component build. That
is
> why I put it in //services/ui/common. Otherwise, it may cause crash for
> component build.

Indeed. That's why I am making the client lib into a shared library:
https://codereview.chromium.org/2189893002

[sadrul, 2016-07-28 13:42:07]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 13:42:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 14:26:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 14:26:12]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-08-10 23:43:36]

Description was changed from

==========
services/ui: Move some files into the client lib.

Move the following out of ui/common into the public client-lib:
. GpuService
. GpuMemoryBufferImpl
. MojoGpuMemoryBuffer
. MojoGpuMemoryBufferManager
. MojoBufferBacking
These are only used by the clients, so there's no reason to build
these into the server as well.


BUG=none
==========

to

==========
services/ui: Move some files into the client lib.

Move the following out of ui/common into the public client-lib:
. GpuService
. GpuMemoryBufferImpl
. MojoGpuMemoryBuffer
. MojoGpuMemoryBufferManager
. MojoBufferBacking
These are only used by the clients, so there's no reason to build
these into the server as well.


BUG=634377
==========

[sadrul, 2016-08-11 04:35:14]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 04:35:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 04:36:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 04:36:57]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sadrul, 2016-08-11 04:52:12]

Patchset #9 (id:160001) has been deleted

[sadrul, 2016-08-11 04:53:21]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 04:53:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 04:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 04:55:11]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sadrul, 2016-08-11 05:01:17]

This is ready for review now. PTAL

[sky, 2016-08-11 13:14:51]

LGTM

[Peng, 2016-08-11 14:09:23]

lgtm

https://codereview.chromium.org/2184943002/diff/180001/content/browser/compos...
File content/browser/compositor/gpu_process_transport_factory.cc (right):

https://codereview.chromium.org/2184943002/diff/180001/content/browser/compos...
content/browser/compositor/gpu_process_transport_factory.cc:66: #include
"services/ui/public/cpp/gpu_service.h"
Is this header file still necessary?

[sadrul, 2016-08-11 14:16:49]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 14:17:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-11 14:19:47]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 14:20:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-11 14:20:08]

Patchset #10 (id:200001) has been deleted

[sadrul, 2016-08-11 14:20:38]

https://codereview.chromium.org/2184943002/diff/180001/content/browser/compos...
File content/browser/compositor/gpu_process_transport_factory.cc (right):

https://codereview.chromium.org/2184943002/diff/180001/content/browser/compos...
content/browser/compositor/gpu_process_transport_factory.cc:66: #include
"services/ui/public/cpp/gpu_service.h"
On 2016/08/11 14:09:23, Peng wrote:
> Is this header file still necessary?

Good catch, no. Removed.

[sadrul, 2016-08-11 14:21:26]

Description was changed from

==========
services/ui: Move some files into the client lib.

Move the following out of ui/common into the public client-lib:
. GpuService
. GpuMemoryBufferImpl
. MojoGpuMemoryBuffer
. MojoGpuMemoryBufferManager
. MojoBufferBacking
These are only used by the clients, so there's no reason to build
these into the server as well.


BUG=634377
==========

to

==========
services/ui: Move some files into the client lib.

Move the following out of ui/common into the public client-lib:
. GpuService
. GpuMemoryBufferImpl
. MojoGpuMemoryBuffer
. MojoGpuMemoryBufferManager
. MojoBufferBacking
These are only used by the clients, so there's no reason to build
these into the server as well.

BUG=634377
TBR=ben@ for trivial content/ changes.
==========

[sadrul, 2016-08-11 14:21:26]

sadrul@chromium.org changed reviewers:
+ ben@chromium.org

[sadrul, 2016-08-11 14:21:58]

+ben@ for trivial changes in content/ (will TBR)

[Ben Goodger (Google), 2016-08-11 14:22:34]

content lgtm

[commit-bot: I haz the power, 2016-08-11 15:04:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 15:04:37]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-08-11 16:04:44]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-08-11 16:04:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
penghuang@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2184943002/#ps220001
(title: ".")

[commit-bot: I haz the power, 2016-08-11 16:05:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 16:10:27]

Description was changed from

==========
services/ui: Move some files into the client lib.

Move the following out of ui/common into the public client-lib:
. GpuService
. GpuMemoryBufferImpl
. MojoGpuMemoryBuffer
. MojoGpuMemoryBufferManager
. MojoBufferBacking
These are only used by the clients, so there's no reason to build
these into the server as well.

BUG=634377
TBR=ben@ for trivial content/ changes.
==========

to

==========
services/ui: Move some files into the client lib.

Move the following out of ui/common into the public client-lib:
. GpuService
. GpuMemoryBufferImpl
. MojoGpuMemoryBuffer
. MojoGpuMemoryBufferManager
. MojoBufferBacking
These are only used by the clients, so there's no reason to build
these into the server as well.

BUG=634377
TBR=ben@ for trivial content/ changes.
==========

[commit-bot: I haz the power, 2016-08-11 16:10:29]

Committed patchset #10 (id:220001)

[commit-bot: I haz the power, 2016-08-11 16:13:29]

Description was changed from

==========
services/ui: Move some files into the client lib.

Move the following out of ui/common into the public client-lib:
. GpuService
. GpuMemoryBufferImpl
. MojoGpuMemoryBuffer
. MojoGpuMemoryBufferManager
. MojoBufferBacking
These are only used by the clients, so there's no reason to build
these into the server as well.

BUG=634377
TBR=ben@ for trivial content/ changes.
==========

to

==========
services/ui: Move some files into the client lib.

Move the following out of ui/common into the public client-lib:
. GpuService
. GpuMemoryBufferImpl
. MojoGpuMemoryBuffer
. MojoGpuMemoryBufferManager
. MojoBufferBacking
These are only used by the clients, so there's no reason to build
these into the server as well.

BUG=634377
TBR=ben@ for trivial content/ changes.

Committed: https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c
Cr-Commit-Position: refs/heads/master@{#411345}
==========

[commit-bot: I haz the power, 2016-08-11 16:13:31]

Patchset 10 (id:??) landed as
https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c
Cr-Commit-Position: refs/heads/master@{#411345}