Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1707)

Issue 2011553008: [Binding] [Refactoring] Move some create() from SerializedScriptValueFactory to SerializedScriptValu (Closed)

Created:
4 years, 7 months ago by peria
Modified:
4 years, 7 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, tzik, Peter Beverloo, sof, eae+blinkwatch, nhiroki, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, falken, horo+watch_chromium.org, blink-reviews, kinuko+serviceworker, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some create() methods, that are independent from V8 isolate and context, from SerializedScriptValueFactory to SerializedScriptValue. BUG=614919 Committed: https://crrev.com/b01d82dcbd2bf830179e5cf611281f8e41e6fe0f Cr-Commit-Position: refs/heads/master@{#396226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -66 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 2 chunks +33 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp View 2 chunks +2 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSerializedScriptValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
peria
PTL
4 years, 7 months ago (2016-05-26 12:30:45 UTC) #3
Yuki
lgtm
4 years, 7 months ago (2016-05-26 13:14:21 UTC) #4
haraken
LGTM
4 years, 7 months ago (2016-05-26 15:47:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011553008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011553008/1
4 years, 7 months ago (2016-05-26 16:10:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 17:59:29 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 18:01:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b01d82dcbd2bf830179e5cf611281f8e41e6fe0f
Cr-Commit-Position: refs/heads/master@{#396226}

Powered by Google App Engine
This is Rietveld 408576698