third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp - Issue 2011553008: [Binding] [Refactoring] Move some create() from SerializedScriptValueFactory to SerializedScriptValu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

Issue 2011553008: [Binding] [Refactoring] Move some create() from SerializedScriptValueFactory to SerializedScriptValu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp ('k') | third_party/WebKit/Source/core/dom/MessagePort.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

index c40d500d2c139b046667da9014bfb1ddd2a59e58..3dbd2b4195ec7eee427514b1316737aa846a1ab0 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

@@ -319,7 +319,7 @@ static v8::Local<v8::Value> deserializeIDBValueData(v8::Isolate* isolate, const

return v8::Null(isolate);

const SharedBuffer* valueData = value->data();

- RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValueFactory::instance().createFromWireBytes(valueData->data(), valueData->size());

+ RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValue::create(valueData->data(), valueData->size());

return serializedValue->deserialize(isolate, nullptr, value->blobInfo());

}