third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp - Issue 2011553008: [Binding] [Refactoring] Move some create() from SerializedScriptValueFactory to SerializedScriptValu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Issue 2011553008: [Binding] [Refactoring] Move some create() from SerializedScriptValueFactory to SerializedScriptValu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/Notification.cpp ('k') | third_party/WebKit/Source/web/WebSerializedScriptValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

index 0ae84e243a33f07d7f30eaef2f923d9989aa0871..68943ef9e2c60390a1a487ec33321eeccd0b6ce9 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

@@ -398,7 +398,7 @@ void ServiceWorkerContainer::dispatchMessageEvent(std::unique_ptr<WebServiceWork

return;

MessagePortArray* ports = MessagePort::toMessagePortArray(getExecutionContext(), webChannels);

- RefPtr<SerializedScriptValue> value = SerializedScriptValueFactory::instance().createFromWire(message);

+ RefPtr<SerializedScriptValue> value = SerializedScriptValue::create(message);

ServiceWorker* source = ServiceWorker::from(getExecutionContext(), adoptPtr(handle.release()));

dispatchEvent(ServiceWorkerMessageEvent::create(ports, value, source, getExecutionContext()->getSecurityOrigin()->toString()));

}