Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 19804005: Remove AtomicStringImpl. (Closed)

Created:
7 years, 5 months ago by Chris Evans
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, do-not-use, Nils Barth (inactive), Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, jchaffraix+rendering, kenneth.christiansen, loislo+blink_chromium.org, darktears, haraken, kojih, jsbell+bindings_chromium.org, leviw+renderwatch, f(malita), Stephen Chennney, jeez
Visibility:
Public.

Description

Remove AtomicStringImpl. This is attempt #2. Attempt #1 was reverted due to some object lifetime issues which were tackled in separate bugs. I also noted the paradigm of RefPtr<AtomicStringImpl> as a map key, which I replaced with functionally-equivalent AtomicString. This may have the advantage of less template specializations. BUG=250050 TEST=layout tests under ASAN ok Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -171 lines) Patch
M Source/bindings/v8/V8WindowShell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelector.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 5 chunks +7 lines, -6 lines 0 comments Download
M Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleFeature.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/RuleSet.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SelectorChecker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CheckedRadioButtons.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/CheckedRadioButtons.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentOrderedMap.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/dom/DocumentOrderedMap.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/TreeScope.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/TreeScope.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/SelectRuleFeatureSet.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/SetNodeAttributeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FormController.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/FormController.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLDocument.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGPathData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/scripts/make_names.pl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStyledElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStyledElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedPropertyDescription.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Forward.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/wtf/text/AtomicString.h View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/wtf/text/AtomicString.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D Source/wtf/text/AtomicStringImpl.h View 1 chunk +0 lines, -38 lines 0 comments Download
M Source/wtf/text/StringImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Evans
This should land and stick this time.
7 years, 5 months ago (2013-07-23 20:30:57 UTC) #1
abarth-chromium
lgtm
7 years, 5 months ago (2013-07-23 20:33:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/19804005/1
7 years, 5 months ago (2013-07-23 21:03:19 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 23:04:34 UTC) #4
Message was sent while issue was closed.
Change committed as 154790

Powered by Google App Engine
This is Rietveld 408576698