Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: Source/core/html/HTMLFormControlsCollection.cpp

Issue 19804005: Remove AtomicStringImpl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLDocument.cpp ('k') | Source/core/html/HTMLFormElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2010, 2011, 2012 Apple Inc. All r ights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2010, 2011, 2012 Apple Inc. All r ights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 return item; 115 return item;
116 116
117 return firstNamedItem(formControlElements(), imagesElements, nameAttr, name) ; 117 return firstNamedItem(formControlElements(), imagesElements, nameAttr, name) ;
118 } 118 }
119 119
120 void HTMLFormControlsCollection::updateNameCache() const 120 void HTMLFormControlsCollection::updateNameCache() const
121 { 121 {
122 if (hasNameCache()) 122 if (hasNameCache())
123 return; 123 return;
124 124
125 HashSet<AtomicStringImpl*> foundInputElements; 125 HashSet<StringImpl*> foundInputElements;
126 126
127 const Vector<FormAssociatedElement*>& elementsArray = formControlElements(); 127 const Vector<FormAssociatedElement*>& elementsArray = formControlElements();
128 128
129 for (unsigned i = 0; i < elementsArray.size(); ++i) { 129 for (unsigned i = 0; i < elementsArray.size(); ++i) {
130 FormAssociatedElement* associatedElement = elementsArray[i]; 130 FormAssociatedElement* associatedElement = elementsArray[i];
131 if (associatedElement->isEnumeratable()) { 131 if (associatedElement->isEnumeratable()) {
132 HTMLElement* element = toHTMLElement(associatedElement); 132 HTMLElement* element = toHTMLElement(associatedElement);
133 const AtomicString& idAttrVal = element->getIdAttribute(); 133 const AtomicString& idAttrVal = element->getIdAttribute();
134 const AtomicString& nameAttrVal = element->getNameAttribute(); 134 const AtomicString& nameAttrVal = element->getNameAttribute();
135 if (!idAttrVal.isEmpty()) { 135 if (!idAttrVal.isEmpty()) {
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 returnValue1Enabled = true; 171 returnValue1Enabled = true;
172 returnValue1 = namedItems.at(0); 172 returnValue1 = namedItems.at(0);
173 return; 173 return;
174 } 174 }
175 175
176 returnValue0Enabled = true; 176 returnValue0Enabled = true;
177 returnValue0 = this->ownerNode()->radioNodeList(name); 177 returnValue0 = this->ownerNode()->radioNodeList(name);
178 } 178 }
179 179
180 } 180 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLDocument.cpp ('k') | Source/core/html/HTMLFormElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698