Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: Source/core/dom/CheckedRadioButtons.cpp

Issue 19804005: Remove AtomicStringImpl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/CheckedRadioButtons.h ('k') | Source/core/dom/DocumentOrderedMap.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 return; 253 return;
254 254
255 m_nameToGroupMap->checkConsistency(); 255 m_nameToGroupMap->checkConsistency();
256 NameToGroupMap::iterator it = m_nameToGroupMap->find(element->name().impl()) ; 256 NameToGroupMap::iterator it = m_nameToGroupMap->find(element->name().impl()) ;
257 if (it == m_nameToGroupMap->end()) 257 if (it == m_nameToGroupMap->end())
258 return; 258 return;
259 it->value->remove(element); 259 it->value->remove(element);
260 if (it->value->isEmpty()) { 260 if (it->value->isEmpty()) {
261 // FIXME: We may skip deallocating the empty RadioButtonGroup for 261 // FIXME: We may skip deallocating the empty RadioButtonGroup for
262 // performance improvement. If we do so, we need to change the key type 262 // performance improvement. If we do so, we need to change the key type
263 // of m_nameToGroupMap from AtomicStringImpl* to RefPtr<AtomicStringImpl >. 263 // of m_nameToGroupMap from StringImpl* to AtomicString.
264 m_nameToGroupMap->remove(it); 264 m_nameToGroupMap->remove(it);
265 if (m_nameToGroupMap->isEmpty()) 265 if (m_nameToGroupMap->isEmpty())
266 m_nameToGroupMap.clear(); 266 m_nameToGroupMap.clear();
267 } 267 }
268 } 268 }
269 269
270 } // namespace 270 } // namespace
OLDNEW
« no previous file with comments | « Source/core/dom/CheckedRadioButtons.h ('k') | Source/core/dom/DocumentOrderedMap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698