Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 19804005: Remove AtomicStringImpl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/css/CSSSelector.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 Frame* frame = 0; 446 Frame* frame = 0;
447 if (node->hasTagName(HTMLNames::iframeTag) && (frame = toHTMLIFrameEleme nt(node)->contentFrame())) 447 if (node->hasTagName(HTMLNames::iframeTag) && (frame = toHTMLIFrameEleme nt(node)->contentFrame()))
448 return toV8(frame->domWindow(), creationContext, isolate); 448 return toV8(frame->domWindow(), creationContext, isolate);
449 return toV8(node, creationContext, isolate); 449 return toV8(node, creationContext, isolate);
450 } 450 }
451 return toV8(items.release(), creationContext, isolate); 451 return toV8(items.release(), creationContext, isolate);
452 } 452 }
453 453
454 static void getter(v8::Local<v8::String> property, const v8::PropertyCallbackInf o<v8::Value>& info) 454 static void getter(v8::Local<v8::String> property, const v8::PropertyCallbackInf o<v8::Value>& info)
455 { 455 {
456 // FIXME: Consider passing AtomicStringImpl directly. 456 // FIXME: Consider passing StringImpl directly.
457 AtomicString name = toWebCoreAtomicString(property); 457 AtomicString name = toWebCoreAtomicString(property);
458 HTMLDocument* htmlDocument = V8HTMLDocument::toNative(info.Holder()); 458 HTMLDocument* htmlDocument = V8HTMLDocument::toNative(info.Holder());
459 ASSERT(htmlDocument); 459 ASSERT(htmlDocument);
460 v8::Handle<v8::Value> result = getNamedProperty(htmlDocument, name, info.Hol der(), info.GetIsolate()); 460 v8::Handle<v8::Value> result = getNamedProperty(htmlDocument, name, info.Hol der(), info.GetIsolate());
461 if (!result.IsEmpty()) { 461 if (!result.IsEmpty()) {
462 v8SetReturnValue(info, result); 462 v8SetReturnValue(info, result);
463 return; 463 return;
464 } 464 }
465 v8::Handle<v8::Value> prototype = info.Holder()->GetPrototype(); 465 v8::Handle<v8::Value> prototype = info.Holder()->GetPrototype();
466 if (prototype->IsObject()) { 466 if (prototype->IsObject()) {
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 void V8WindowShell::updateSecurityOrigin() 507 void V8WindowShell::updateSecurityOrigin()
508 { 508 {
509 ASSERT(m_world->isMainWorld()); 509 ASSERT(m_world->isMainWorld());
510 if (m_context.isEmpty()) 510 if (m_context.isEmpty())
511 return; 511 return;
512 v8::HandleScope handleScope; 512 v8::HandleScope handleScope;
513 setSecurityToken(); 513 setSecurityToken();
514 } 514 }
515 515
516 } // WebCore 516 } // WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/CSSSelector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698