[MD History] Unify query state in history-app.

[MD History] Unify query state in history-app.

This CL unifies several concepts in the History page into a single
property that lives in the history-app element and moves query logic
into history-app as well.

This refactor will enable the implementation of grouped history.

BUG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8206afea7755f79ebc9dd1a8452b521d23946eee
Cr-Commit-Position: refs/heads/master@{#394358}

[calamity, 2016-05-12 07:13:26]

Description was changed from

==========
[MD History] Unify query state in history-app.

This CL unifies several concepts in the History page into a single
property that lives in the history-app element and moves query logic
into history-app as well.

This refactor will enable the implementation of grouped history.

BUG=589357
==========

to

==========
[MD History] Unify query state in history-app.

This CL unifies several concepts in the History page into a single
property that lives in the history-app element and moves query logic
into history-app as well.

This refactor will enable the implementation of grouped history.

BUG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-05-12 07:40:45]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[calamity, 2016-05-12 07:40:46]

#enjoy

[tsergeant, 2016-05-13 03:41:06]

https://codereview.chromium.org/1974713002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.html (right):

https://codereview.chromium.org/1974713002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/app.html:53:
searched-term="{{queryState_.info.term}}">
If I'm reading this correctly, this will set searchedTerm before the results
actually come from the backend?

Does this have any side effects? Eg, changing "100 results for Search 1" to "100
results for Search 2" before the results change.

Having searchedTerm be inconsistent scares me a little.

https://codereview.chromium.org/1974713002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_item_test.js (right):

https://codereview.chromium.org/1974713002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_item_test.js:50: element.searchedTerm
= 'search';
Related to previous question, is searchedTerm expected to be set before
addNewResults?

searchedTerm is necessary for needsTimeGap_, which is computed when the
iron-list updates...and it's unclear whether that is done immediately or
deferred.

Even if the way you've written it here is correct, there's the possibility for
this test to give a false positive (It would be pass even if searchTerm == ''),
so we should probably fix that.

https://codereview.chromium.org/1974713002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_list_test.js (left):

https://codereview.chromium.org/1974713002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_list_test.js:109:
console.log(element.historyData[0].timestamps);
lol

[calamity, 2016-05-18 01:41:52]

https://codereview.chromium.org/1974713002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.html (right):

https://codereview.chromium.org/1974713002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/app.html:53:
searched-term="{{queryState_.info.term}}">
On 2016/05/13 03:41:06, tsergeant wrote:
> If I'm reading this correctly, this will set searchedTerm before the results
> actually come from the backend?
> 
> Does this have any side effects? Eg, changing "100 results for Search 1" to
"100
> results for Search 2" before the results change.
> 
> Having searchedTerm be inconsistent scares me a little.

As discussed, this is set when the query returns.

https://codereview.chromium.org/1974713002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_item_test.js (right):

https://codereview.chromium.org/1974713002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_item_test.js:50: element.searchedTerm
= 'search';
On 2016/05/13 03:41:06, tsergeant wrote:
> Related to previous question, is searchedTerm expected to be set before
> addNewResults?
> 
> searchedTerm is necessary for needsTimeGap_, which is computed when the
> iron-list updates...and it's unclear whether that is done immediately or
> deferred.
> 
> Even if the way you've written it here is correct, there's the possibility for
> this test to give a false positive (It would be pass even if searchTerm ==
''),
> so we should probably fix that.

Fixed this test.

https://codereview.chromium.org/1974713002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_list_test.js (left):

https://codereview.chromium.org/1974713002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_list_test.js:109:
console.log(element.historyData[0].timestamps);
On 2016/05/13 03:41:06, tsergeant wrote:
> lol

Acklolaged.

[tsergeant, 2016-05-18 04:14:17]

lgtm

[calamity, 2016-05-18 07:10:16]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-05-18 07:10:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974713002/40001

[commit-bot: I haz the power, 2016-05-18 08:13:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-18 08:14:51]

Description was changed from

==========
[MD History] Unify query state in history-app.

This CL unifies several concepts in the History page into a single
property that lives in the history-app element and moves query logic
into history-app as well.

This refactor will enable the implementation of grouped history.

BUG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Unify query state in history-app.

This CL unifies several concepts in the History page into a single
property that lives in the history-app element and moves query logic
into history-app as well.

This refactor will enable the implementation of grouped history.

BUG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8206afea7755f79ebc9dd1a8452b521d23946eee
Cr-Commit-Position: refs/heads/master@{#394358}
==========

[commit-bot: I haz the power, 2016-05-18 08:14:52]

Patchset 3 (id:??) landed as
https://crrev.com/8206afea7755f79ebc9dd1a8452b521d23946eee
Cr-Commit-Position: refs/heads/master@{#394358}