Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1972073002: [MD History] Make history-list:historyData private. (Closed)

Created:
4 years, 7 months ago by calamity
Modified:
4 years, 7 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_loading
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Make history-list:historyData private. BUG=589357 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f39dc7160e9a7b5bd1a49bf517c50955879c2896 Cr-Commit-Position: refs/heads/master@{#394660}

Patch Set 1 #

Total comments: 2

Patch Set 2 : oopz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M chrome/browser/resources/md_history/history_list.html View 1 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/md_history/history_list.js View 1 11 chunks +29 lines, -29 lines 0 comments Download
M chrome/test/data/webui/md_history/history_item_test.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/md_history/history_list_test.js View 1 3 chunks +15 lines, -15 lines 0 comments Download
M chrome/test/data/webui/md_history/history_supervised_user_test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/md_history/history_toolbar_test.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1974713002 Patch 40001

Dependent Patchsets:

Issue 1993613002 Patch 40001

Messages

Total messages: 11 (5 generated)
calamity
4 years, 7 months ago (2016-05-18 06:13:07 UTC) #3
tsergeant
lgtm % nit (hooray find-and-replace) https://codereview.chromium.org/1972073002/diff/1/chrome/browser/resources/md_history/history_list.js File chrome/browser/resources/md_history/history_list.js (right): https://codereview.chromium.org/1972073002/diff/1/chrome/browser/resources/md_history/history_list.js#newcode225 chrome/browser/resources/md_history/history_list.js:225: hasResults: function(historyData_Length) { Nit: ...
4 years, 7 months ago (2016-05-18 06:44:03 UTC) #4
calamity
https://codereview.chromium.org/1972073002/diff/1/chrome/browser/resources/md_history/history_list.js File chrome/browser/resources/md_history/history_list.js (right): https://codereview.chromium.org/1972073002/diff/1/chrome/browser/resources/md_history/history_list.js#newcode225 chrome/browser/resources/md_history/history_list.js:225: hasResults: function(historyData_Length) { On 2016/05/18 06:44:02, tsergeant wrote: > ...
4 years, 7 months ago (2016-05-18 07:14:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972073002/20001
4 years, 7 months ago (2016-05-19 01:56:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 03:58:55 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 04:00:12 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f39dc7160e9a7b5bd1a49bf517c50955879c2896
Cr-Commit-Position: refs/heads/master@{#394660}

Powered by Google App Engine
This is Rietveld 408576698